Closed Bug 2027195 Opened 8 months ago Closed 7 months ago

Active tab position

Categories

(Firefox for Android :: Tabs, task, P1)

Firefox 149
All
Android
task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed
firefox152 --- verified

People

(Reporter: ryfrazier, Assigned: giorga)

References

Details

(Whiteboard: [fxdroid][group4])

Attachments

(1 file, 1 external file, 1 obsolete file)

We need to adjust the position of the active tab in both the grid and list view such that the tab / list item sits in the lower portion of the screen (to be easier for the thumb to reach)

Assignee: nobody → giorga
Attachment #9564109 - Attachment is obsolete: true
Severity: -- → N/A
Type: defect → task
Pushed by giorga@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3ea66e9ab46e https://hg.mozilla.org/integration/autoland/rev/501b2ee64821 Adjust the position of the active tab in both the grid and list view such that the tab/list item sits in the lower portion of the screen. r=android-reviewers,jdelorenzo
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Regressions: 2032117
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b3b5a58d1ffd https://hg.mozilla.org/integration/autoland/rev/3b5c70d39350 Revert "Bug 2027195 - Adjust the position of the active tab in both the grid and list view such that the tab/list item sits in the lower portion of the screen. r=android-reviewers,jdelorenzo" as requested by dev.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 151 Branch → ---
Pushed by giorga@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/411155472404 https://hg.mozilla.org/integration/autoland/rev/bce6c77d5044 Adjust the position of the active tab in both the grid and list view such that the tab/list item sits in the lower portion of the screen. r=android-reviewers,jdelorenzo
Status: REOPENED → RESOLVED
Closed: 7 months ago → 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Regressions: 2033318
Regressions: 2033339

I paired with Julie for a bit today to examine the regressions, and we could no longer locally reproduce Bug 2033318 after adding Gabi's patch for Bug 2033339.

We're landing it today and we'll see if the issue has been resolved.

Regressions: 2033567
Flags: qe-verify+

Verified on the latest Firefox for Android Nightly 152.0a1 from 4/23 using a Samsung Galaxy S24 (Android 16), and a Pixel 6 (Android 17).
The highlighted tabs from the bottom of the tabs tray are under the "search / menu" and "new tab" buttons. Is this intended?

Flags: needinfo?(ryfrazier)
Flags: qe-verify+

This is not intended. We probably just need to account for the 200dp or so of padding at the bottom when calculating the scroll offset.

Let's get a new bug on file for this and move the discussion there.

Gabi - can you take a look into this?

Flags: needinfo?(ryfrazier) → needinfo?(giorga)

Do we have a bug for it ?

Flags: needinfo?(giorga)
See Also: → 2035470

Gabriel, I just filed Bug 2035470.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: