Closed Bug 2027201 Opened 1 month ago Closed 9 days ago

[wpt-sync] Sync PR 58726 - script: Remove check for zero request body length in `FetchLater`

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58726 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58726
Details from upstream follow.

Tim van der Lippe <tvanderlippe@gmail.com> wrote:

script: Remove check for zero request body length in FetchLater

Per the spec discussion in 1 we should only check for a length of null and not zero.

Reviewed in servo/servo#43627

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 20 tests and 6 subtests

Status Summary

Firefox

OK : 1[GitHub] 13[Gecko-linux2404-64-debug, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 14[Gecko-linux2404-64-opt] 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
PASS : 6
FAIL : 15[GitHub] 54[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 55[Gecko-windows11-32-24h2-debug]
TIMEOUT: 1
ERROR : 1[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 2[Gecko-linux2404-64-opt, GitHub] 3[Gecko-linux2404-64-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 4[Gecko-windows11-32-24h2-debug]
NOTRUN : 2

Chrome

OK : 1
PASS : 11
FAIL : 10
ERROR : 2

Safari

OK : 2
PASS : 6
FAIL : 15
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fetch/fetch-later/quota/cross-origin-iframe/max-payload.https.window.html [wpt.fyi]: ERROR [Gecko-windows11-32-24h2-debug], SKIP [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
    • fetchLater() accepts max payload in a parent-frame-origin POST request body of String in a default cross-origin iframe.: FAIL
    • fetchLater() rejects max+1 payload in a parent-frame-origin POST request body of String in a default cross-origin iframe.: TIMEOUT
    • fetchLater() accepts max payload in a self-frame-origin POST request body of String in a default cross-origin iframe.: NOTRUN
    • fetchLater() rejects max+1 payload in a self-frame-origin POST request body of String in a default cross-origin iframe.: NOTRUN
  • /fetch/fetch-later/quota/cross-origin-iframe/oversized-payload.https.window.html [wpt.fyi]: SKIP
  • /fetch/fetch-later/quota/same-origin-iframe/max-payload.https.window.html [wpt.fyi]: SKIP
  • /fetch/fetch-later/quota/same-origin-iframe/oversized-payload.https.window.html [wpt.fyi]: SKIP
  • /fetch/fetch-later/quota/accumulated-oversized-payload.https.window.html [wpt.fyi]
    • The 2nd fetchLater(same-origin) call in the top-level document is not allowed to exceed per-origin quota for its POST body of String.: FAIL
  • /fetch/fetch-later/quota/cross-origin-iframe/accumulated-oversized-payload.https.window.html [wpt.fyi]
    • The 2nd fetchLater(same-origin) call in a default cross-origin child iframe has its owned per-origin quota for a request POST body of String.: FAIL
  • /fetch/fetch-later/quota/cross-origin-iframe/empty-payload.https.window.html [wpt.fyi]: ERROR [Gecko-linux2404-64-debug, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], OK [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt] (Chrome: ERROR, Safari: OK)
    • fetchLater() accepts an empty POST request body of String in a default cross-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of ArrayBuffer in a default cross-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of FormData in a default cross-origin iframe.: FAIL (Chrome: PASS, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of URLSearchParams in a default cross-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of Blob in a default cross-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of File in a default cross-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/fetch-later/quota/cross-origin-iframe/multiple-iframes.https.window.html [wpt.fyi]
    • fetchLater() request quota are delegated to cross-origin iframes and not shared, even if they are same origin.: FAIL
  • /fetch/fetch-later/quota/cross-origin-iframe/sandboxed-iframe.https.window.html [wpt.fyi]
    • A sandboxed iframe (without allow-same-origin) should be treated as cross-origin and have its own minimal quota.: FAIL
  • /fetch/fetch-later/quota/cross-origin-iframe/small-payload.https.window.html [wpt.fyi]: ERROR [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], OK [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
    • fetchLater() accepts payload[size=20] in a POST request body of String in a default cross-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of ArrayBuffer in a default cross-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of FormData in a default cross-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of URLSearchParams in a default cross-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of Blob in a default cross-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of File in a default cross-origin iframe.: FAIL
  • /fetch/fetch-later/quota/empty-payload.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
    • fetchLater() accept a GET request.: FAIL (Chrome: PASS, Safari: FAIL)
    • fetchLater() accept a DELETE request.: FAIL (Chrome: PASS, Safari: FAIL)
    • fetchLater() accept a PUT request.: FAIL (Chrome: PASS, Safari: FAIL)
  • /fetch/fetch-later/quota/max-payload.https.window.html [wpt.fyi]
    • fetchLater() accepts max payload in a POST request body of String.: FAIL
    • fetchLater() rejects max+1 payload in a POST request body of String.: FAIL
  • /fetch/fetch-later/quota/multiple-origins.https.window.html [wpt.fyi]
    • fetchLater() has per-request-origin quota for its POST body of String.: FAIL
    • fetchLater() has per-request-origin quota for its POST body of ArrayBuffer.: FAIL
    • fetchLater() has per-request-origin quota for its POST body of FormData.: FAIL
    • fetchLater() has per-request-origin quota for its POST body of URLSearchParams.: FAIL
    • fetchLater() has per-request-origin quota for its POST body of Blob.: FAIL
    • fetchLater() has per-request-origin quota for its POST body of File.: FAIL
  • /fetch/fetch-later/quota/oversized-payload.https.window.html [wpt.fyi]
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of String.: FAIL
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of ArrayBuffer.: FAIL
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of FormData.: FAIL
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of URLSearchParams.: FAIL
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of Blob.: FAIL
    • fetchLater() does not accept payload[size=65537] exceeding per-origin quota in a POST request body of File.: FAIL
  • /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html [wpt.fyi]
    • The 2nd fetchLater(same-origin) call in a same-origin child iframe is not allowed to exceed per-origin quota for its POST body of String.: FAIL
  • /fetch/fetch-later/quota/same-origin-iframe/empty-payload.https.window.html [wpt.fyi]
    • fetchLater() accepts an empty POST request body of String in same-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of ArrayBuffer in same-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of FormData in same-origin iframe.: FAIL (Chrome: PASS, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of URLSearchParams in same-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of Blob in same-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
    • fetchLater() accepts an empty POST request body of File in same-origin iframe.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html [wpt.fyi]
    • fetchLater() request quota are shared by same-origin iframes and root.: FAIL
  • /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html [wpt.fyi]
    • A sandboxed iframe with 'allow-same-origin' should be treated as same-origin and share the parent's quota.: FAIL
  • /fetch/fetch-later/quota/same-origin-iframe/small-payload.https.window.html [wpt.fyi]
    • fetchLater() accepts payload[size=20] in a POST request body of String in same-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of ArrayBuffer in same-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of FormData in same-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of URLSearchParams in same-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of Blob in same-origin iframe.: FAIL
    • fetchLater() accepts payload[size=20] in a POST request body of File in same-origin iframe.: FAIL
  • /fetch/fetch-later/quota/small-payload.https.window.html [wpt.fyi]
    • fetchLater() accepts small payload in a POST request body of String.: FAIL
    • fetchLater() accepts small payload in a POST request body of ArrayBuffer.: FAIL
    • fetchLater() accepts small payload in a POST request body of FormData.: FAIL
    • fetchLater() accepts small payload in a POST request body of URLSearchParams.: FAIL
    • fetchLater() accepts small payload in a POST request body of Blob.: FAIL
    • fetchLater() accepts small payload in a POST request body of File.: FAIL

Tests Disabled in Gecko Infrastructure

https://hg.mozilla.org/mozilla-central/rev/2500a40bd323
https://hg.mozilla.org/mozilla-central/rev/849c57f39ce9

Status: NEW → RESOLVED
Closed: 9 days ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.