Closed
Bug 2027213
Opened 5 months ago
Closed 3 months ago
Avoid having "windows.h" in header files in WebSerial
Categories
(Core :: DOM: Web Serial, task)
Core
DOM: Web Serial
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: gstoll, Assigned: gstoll)
References
Details
Attachments
(1 file)
See suggestion here
|
Assignee | |
Comment 1•3 months ago
|
||
I also tried inlining a bunch of PosixSerialPlatformService.h into the
.cpp file and similar for Win32, but this caused a lot of code churn
and I couldn't get it to work for Win32 (something to do with including
<windows.h> and getting mozilla:: prefixed versions of DWORD). Anyway,
this change still avoids including <windows.h> in anything other than
Win32SerialPlatformService.h, which is now only included from
Win32SerialPlatformService.cpp.
|
||
Updated•3 months ago
|
Assignee: nobody → gstoll
Status: NEW → ASSIGNED
Pushed by gstoll@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/4efc915d58e1
https://hg.mozilla.org/integration/autoland/rev/62a26c73ce67
don't include <windows.h> when we can avoid it r=cmartin
|
||
Comment 3•3 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
|
||
Updated•2 months ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
|
||
Updated•1 month ago
|
Component: DOM: Device Interfaces → Dom: Web Serial
You need to log in
before you can comment on or make changes to this bug.
Description
•