Closed Bug 2027218 Opened 22 days ago Closed 9 days ago

Perma ES-B [tier 2] [taskcluster:error] exit status 1 | A configuration object specifies rule "mozilla/valid-services-property", but could not find plugin "mozilla".

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Tracking

(firefox-esr140 unaffected, firefox149 unaffected, firefox150 unaffected, firefox151+ fixed)

RESOLVED FIXED
151 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox149 --- unaffected
firefox150 --- unaffected
firefox151 + fixed

People

(Reporter: intermittent-bug-filer, Assigned: standard8)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file, 1 obsolete file)

Filed by: rperta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=556287322&repo=mozilla-central&task=fbD1cymdRGyZQDEVcthKrA.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fbD1cymdRGyZQDEVcthKrA/runs/0/artifacts/public/logs/live_backing.log


[task 2026-03-28T00:15:01.714+00:00]   File "/builds/worker/checkouts/gecko/python/mozlint/mozlint/roller.py", line 95, in _run_worker
[task 2026-03-28T00:15:01.714+00:00]     assert False
[task 2026-03-28T00:15:01.714+00:00] AssertionError
[task 2026-03-28T00:15:01.714+00:00] 00:15:01.714 eslint (182) | Finished in 24.71 seconds
[task 2026-03-28T00:15:01.714+00:00] An error occurred running eslint. Please check the following error messages:
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] Oops! Something went wrong! :(
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] ESLint: 9.39.1
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] A configuration object specifies rule "mozilla/valid-services-property", but could not find plugin "mozilla".
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] Common causes of this problem include:
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] 1. The "mozilla" plugin is not defined in your configuration file.
[task 2026-03-28T00:15:01.714+00:00] 2. The "mozilla" plugin is not defined within the same configuration object in which the "mozilla/valid-services-property" rule is applied.
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.714+00:00] 
[task 2026-03-28T00:15:01.839+00:00] 00:15:01.839 eslint (185) | Unexpected result type received: <class 'int'>
[task 2026-03-28T00:15:01.839+00:00] 00:15:01.839 eslint (185) | eslint failed
[task 2026-03-28T00:15:01.839+00:00] Traceback (most recent call last):
[task 2026-03-28T00:15:01.839+00:00]   File "/builds/worker/checkouts/gecko/python/mozlint/mozlint/roller.py", line 95, in _run_worker
[task 2026-03-28T00:15:01.839+00:00]     assert False
[task 2026-03-28T00:15:01.839+00:00] AssertionError
[task 2026-03-28T00:15:01.840+00:00] 00:15:01.839 eslint (185) | Finished in 24.84 seconds
[task 2026-03-28T00:15:01.840+00:00] An error occurred running eslint. Please check the following error messages:
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] Oops! Something went wrong! :(
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] ESLint: 9.39.1
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] A configuration object specifies rule "mozilla/valid-services-property", but could not find plugin "mozilla".
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] Common causes of this problem include:
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] 1. The "mozilla" plugin is not defined in your configuration file.
[task 2026-03-28T00:15:01.840+00:00] 2. The "mozilla" plugin is not defined within the same configuration object in which the "mozilla/valid-services-property" rule is applied.
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.840+00:00] 
[task 2026-03-28T00:15:01.874+00:00] No lint issues found.
[taskcluster 2026-03-28T00:15:05.378Z]                        Exit Code: 1
[taskcluster 2026-03-28T00:15:05.378Z]                        User Time: 25.145ms
[taskcluster 2026-03-28T00:15:05.378Z]                      Kernel Time: 21.865ms
[taskcluster 2026-03-28T00:15:05.378Z]                        Wall Time: 2m52.887794525s
[taskcluster 2026-03-28T00:15:05.378Z]  Average Available System Memory: 28.64 GiB
[taskcluster 2026-03-28T00:15:05.378Z]       Average System Memory Used: 2.70 GiB
[taskcluster 2026-03-28T00:15:05.378Z]          Peak System Memory Used: 4.89 GiB
[taskcluster 2026-03-28T00:15:05.378Z]              Total System Memory: 31.34 GiB
[taskcluster 2026-03-28T00:15:05.378Z]                           Result: FAILED
[taskcluster 2026-03-28T00:15:05.384Z] === Task Finished ===
[taskcluster 2026-03-28T00:15:05.384Z] Task Duration: 2m52.893723998s
[taskcluster 2026-03-28T00:15:07.021Z] [mounts] Preserving cache: Moving "/home/task_177465668764633/cache0" to "/home/generic-worker/caches/UTeNZ7g6RqG8JTVxA3A5wQ"
[taskcluster 2026-03-28T00:15:07.021Z] [mounts] Preserving cache: Moving "/home/task_177465668764633/cache1" to "/home/generic-worker/caches/eKViQ-hdQdGyFTvB-FR2Bg"
[taskcluster 2026-03-28T00:15:07.021Z] [mounts] Preserving cache: Moving "/home/task_177465668764633/cache2" to "/home/generic-worker/caches/O2YAVBPaRj2TEloKe5SIng"
[taskcluster 2026-03-28T00:15:07.021Z] [mounts] Preserving cache: Moving "/home/task_177465668764633/cache3" to "/home/generic-worker/caches/V-awqda0RFKJdxKqf7VLGg"
[taskcluster:error] exit status 1

Hi @Sylvestre, do you think that this failure has anything to do with your commit Could you please take a look? Thank you!

Flags: needinfo?(sledru)
Summary: Perma ES-B [tier 2] [taskcluster:error] exit status 1 → Perma ES-B [tier 2] [taskcluster:error] exit status 1 | A configuration object specifies rule "mozilla/valid-services-property", but could not find plugin "mozilla".

This is strange, I can reproduce with MOZ_OBJDIR=objdir-ff-opt ./mach eslint --rule="mozilla/valid-ci-uses: error" toolkit/components/search on the revision prior to when this started on CI.

Which implies that infra wasn't picking this up, and then suddenly started seeing it.

At a quick glance, I can't see anything in the logs that would be different, and my suspicion is that this should have been an issue for a long while. I can have a look at this tomorrow unless anyone else has ideas.

Flags: needinfo?(standard8)
Keywords: regression
Regressed by: 2025532

Set release status flags based on info from the regressing bug 2025532

The issue here is that prior to bug 2025532, the tests had been passing because they weren't passing the following arguments to ESLint: --quiet --rule mozilla/valid-services-property: error --rule mozilla/valid-ci-uses: error.

The builders are meant to be running ESLint with the additional rules enabled, however, since the arguments weren't passed, they were just running the normal ESLint runs.

Everything was working at the end of last October (as evidenced by bug 1997477), but broke somewhere since then. I would assume that the argument passing broke somewhere along the way, and then running the rules also broke afterwards. Now the arguments passing has been fixed, we need to fix running the rules themselves.

That looks to be fairly easy to fix, but we'll also need to fix some issues that have crept in since then.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Flags: needinfo?(sledru)
Priority: P5 → P2

Not really a regression from bug 2025532.

No longer regressed by: 2025532
See Also: → 2025532

For the newer configurations we must pass an argument specifying the plugin to use when loading rules. Hence
this adds a '--plugin' option for the ESLint command, and uses it for the eslint-build builder.

Additionally this updates the valid-ci-uses rule with a couple of new interfaces that have been recently
added, to fix the currently broken tests.

Attachment #9562374 - Attachment is obsolete: true
Pushed by mbanner@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b139c7975c02 https://hg.mozilla.org/integration/autoland/rev/703e497e505d Fix running ESLint with additional rules. r=linter-reviewers,frontend-codestyle-reviewers,sergesanspaille,Gijs
Regressions: 2029075
Status: ASSIGNED → RESOLVED
Closed: 15 days ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

Hi @mark

After this push was merged to central the fail did not change. It still fails with

A configuration object specifies rule "mozilla/valid-services-property", but could not find plugin "mozilla".

Last merge here

Status: RESOLVED → REOPENED
Flags: needinfo?(standard8)
Resolution: FIXED → ---
Target Milestone: 151 Branch → ---
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/23f3a0a883f8 https://hg.mozilla.org/integration/autoland/rev/4b55f8eb4f2d Revert "Bug 2027218 - Fix running ESLint with additional rules. r=linter-reviewers,frontend-codestyle-reviewers,sergesanspaille,Gijs" for not fixing the issue.
See Also: → 2030097
Pushed by mbanner@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f0e783bee34e https://hg.mozilla.org/integration/autoland/rev/deed572e3a65 Fix running ESLint with additional rules. r=linter-reviewers,frontend-codestyle-reviewers,sergesanspaille,Gijs
Status: REOPENED → RESOLVED
Closed: 15 days ago9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: