2027756 - Crash in [@ WakeLockTopic::UninhibitScreensaver]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

8 crashes from 3 installs with the latest Firefox 151.0a1 on Linux

Crash report: https://crash-stats.mozilla.org/report/index/0bef6df0-0db4-43ae-a6b2-27f400260330

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(mWakeLockType != Unsupported) (Uh oh, how did we get here?)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, long)  mfbt/Assertions.h:235
0  libxul.so  WakeLockTopic::UninhibitScreensaver()  widget/gtk/WakeLockListener.cpp:897
0  libxul.so  WakeLockListener::SetState(nsTSubstring<char16_t> const&, bool, bool)  widget/gtk/WakeLockListener.cpp:1104
1  libxul.so  WakeLockListener::Callback(nsTSubstring<char16_t> const&, nsTSubstring<char16...  widget/gtk/WakeLockListener.cpp:1124
2  libxul.so  mozilla::dom::power::PowerManagerService::Notify(mozilla::hal::WakeLockInform...  dom/power/PowerManagerService.cpp:80
3  libxul.so  mozilla::ObserverList<mozilla::hal::WakeLockInformation>::Broadcast(mozilla::...  xpcom/ds/Observer.h:64
3  libxul.so  mozilla::hal::ObserversManager<mozilla::hal::WakeLockInformation>::BroadcastI...  hal/Hal.cpp:169
3  libxul.so  mozilla::hal::NotifyWakeLockChange(mozilla::hal::WakeLockInformation const&)  hal/Hal.cpp:367
4  libxul.so  mozilla::hal_impl::ModifyWakeLockWithChildID(nsTSubstring<char16_t> const&, m...  hal/HalWakeLock.cpp:234
5  libxul.so  mozilla::hal_sandbox::HalParent::RecvModifyWakeLock(nsTSubstring<char16_t> co...  hal/sandbox/SandboxHal.cpp:270

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Hm, this is really something which should not happen.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2027756 [Linux] Early return from WakeLockTopic::UninhibitScreensaver() if wake lock is not available r?emilio

Comment 3

[David Shin[:dshin]]

Hopefully this helps - I can seem to get it to crash pretty reliably by:

1. Go on youtube
2. Allow autoplay
3. Open a video in new tab (Active tab doesn't change)
4. Wait for the sound icon to show up for the new tab
5. Switch to that tab

Comment 4

[David Shin[:dshin]]

Attachment: Log with MOZ_LOG=LinuxWakeLock:5

FWIW, I ran into this with Arch + i3 setup, and as per :emilio's suggestion, I gathered logs, as attached

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ae8fbfbb9c9
https://hg.mozilla.org/integration/autoland/rev/6563fb5691d7
[Linux] Early return from WakeLockTopic::UninhibitScreensaver() if wake lock is not available r=emilio

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6563fb5691d7