202792 - strict-js warnings at Firebird startup

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Chu Alan "sprite"]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030420 Phoenix/0.5+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030420 Phoenix/0.5+

1) redeclaration of currentIndex (interesting code dup, copy and paste error?)
2) redeclaration of uniqueId
3) makes insertItem returns null on failure (previously return;)


Reproducible: Always

Steps to Reproduce:

Comment 1

[Chu Alan "sprite"]

Attachment: fix

Comment 2

[David Tenser [:djst]]

What warning are you talking about?

Comment 3

[Chu Alan "sprite"]

you may need to turn on show strict warnings to get those warning messages...

Comment 4

[noririty]

confirming.
-> NEW
-> minor

Steps to Reproduce:
1. Add the following code to your user.js file:
user_pref("javascript.options.strict", true);
user_pref("javascript.options.showInConsole", true);
2. Restart Firebird Browser and Open JavaScript Console.

Actual Results:  
*******************************************************
Warning: redeclaration of var uniqueId
Source File: chrome://global/content/widgets/toolbar.xml#toolbar.insertItem()
Line: 13, Column: 18
Source Code:
              var uniqueId = (new Date()).getTime()+this.childNodes.length;

Warning: redeclaration of var uniqueId
Source File: chrome://global/content/widgets/toolbar.xml#toolbar.insertItem()
Line: 19, Column: 18
Source Code:
              var uniqueId = (new Date()).getTime()+this.childNodes.length;

Warning: function insertItem does not always return a value
Source File: chrome://global/content/widgets/toolbar.xml#toolbar.insertItem()
Line: 53, Column: 26
Source Code:
            return newItem;

Warning: redeclaration of var currentIndex
Source File: chrome://global/content/widgets/tabbrowser.xml#tabbrowser.removeTab()
Line: 47, Column: 16
Source Code:
            var currentIndex = this.mPanelContainer.selectedIndex;

Expected Results:  
No Warnings.

Comment 5

[Chu Alan "sprite"]

Comment on attachment 121192 [details] [diff] [review]
fix

chanial, you are the only one I know which is currently working on Firebird :)

Comment 6

[Simon Paquet [:sipaq]]

*** Bug 213226 has been marked as a duplicate of this bug. ***

Comment 7

[Simon Paquet [:sipaq]]

Reassigning to Ben as per comment 2 in bug 213226.

Comment 8

[Brant Gurganus]

This patch looks fine to me, its the same thing I did in the patch on bug 213226

Comment 9

[noririty]

Comment on attachment 121192 [details] [diff] [review]
fix

looking good.

Comment 10

[noririty]

checked in.

Comment 11

[Simon Paquet [:sipaq]]

verified with 20030723 trunk build on W2K.

Comment 12

[Simon Paquet [:sipaq]]

Taking QA Contact