2027952 - mozilla::GetLinkActiveInfo can take a long time on macOS

Status: NEW

(Core :: Graphics: CanvasWebGL, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

See https://share.firefox.dev/47vJTTs which is a profile of the test case from bug 918941 comment 22

Comment 1

[Bob Hood [:bhood]]

Dropping this into triage for the team to look at.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

In my testing it seems like glpABIGetStructTypeRangeOfField gets more expensive as the array gets larger and it gets called O(number of array elements) times.

Comment 3

[Ashley Hale [:ahale]]

NeedInfo - do we have anyone who wants to take a look at this?

Context: I recall Kelsey mentioned this slow compile bug is caused by Apple having a particularly slow implementation of glGetActiveUniformsiv, where other vendors have a caching implementation that answers quickly after the first call, so we should cache this ourselves across calls for the same program identifier. Entirely going by memory here, but that's what I remember.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Do we query the same information multiple times?

Comment 5

[Brad Werth [:bradwerth]]

We'll pursue this when Bug 2027951 lands.