2028058 - Can't reliably add new lines in the HTML Editor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to data:text/html,<meta charset=utf8><h1>Hello
2. Inspect the Hello element
3. In the markup view, Right click on the <h1> node to edit the html
4. One the editor is displayed, hit Enter

Expected results

I get a new line at the top of the editor

Actual results

Nothing happens

---

It used to work in cm5

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1991431

:bomsy, since you are the author of the regressor, bug 1991431, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

Hi Bomsy,

This is a relatively recent regression set as P2, do you have the bandwidth to take a look or should we go ahead?

Comment 3

[Julian Descottes [:jdescottes]]

See above.

Comment 4

[Julian Descottes [:jdescottes]]

Taking a look at this one.

Comment 5

[Julian Descottes [:jdescottes]]

The root cause of the issue is that codemirror6 adds BR elements which don't seem to play nicely with the xhtml document of the markup view.
Specifically this is coming from document.createElement("BR"), which creates <BR> elements which are not recognized in XHTML.

And in general all the node name comparisons in the bundle which use hardcoded uppercase tag names will fail.

It seems like CM6 doesn't intend to support XHTML according to https://discuss.codemirror.net/t/codemirror-6-embedded-in-xhtml/3165/4

I can see a few paths here, not sure which one makes the most sense:

• wrap CM6 in an iframe when used in the inspector. Should be relatively easy, this is mostly about using appendTo instead of appendToLocalElement, but I'm not sure if this might break some features?
• monkeypatch cm6 to at least fix the node names to be lowercase. Fixes this issue, but adds recurring maintenance burden and potentially doesn't address all XHTML/CM6 issues
• migrate inspector/markupview from XHTML to HTML. Potentially the most expensive solution.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 2028058 - [devtools] Wrap CM6 editor in an iframe to avoid XHTML incompatibility in inspector

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 2028058 - [devtools] Migrate markup view from XHTML to HTML

Comment 8

[Julian Descottes [:jdescottes]]

I'm uploading patches for the iframe and XHTML -> HTML approaches, let's see what try says for those. We can try monkeypatching if both strategies fail.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e114f941947c
https://hg.mozilla.org/integration/autoland/rev/60c7b7bef479
[devtools] Migrate markup view from XHTML to HTML r=devtools-reviewers,nchevobbe

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/60c7b7bef479

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 12

[Julian Descottes [:jdescottes]]

Moving 152 to wontfix, I prefer to let this bake on nightly as much as possible.