2028075 - [wdspec] bidi/browsing_context/reload/frame.py is not awaiting last assert

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

This test is incorrect https://searchfox.org/firefox-main/rev/9a3317a65545e83f4e32b94fdf1f6860342423ef/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/reload/frame.py#10-11,29-31

@pytest.mark.parametrize("domain", ["", "alt"], ids=["same_origin", "cross_origin"])
async def test_origin(bidi_session, new_tab, inline, domain):
...
    # Reload and assert (frame).
    reload_and_assert(bidi_session, frame, last_navigation=result["navigation"], url=frame_url)

In theory we should await reload_and_assert, but the issue is that this helper doesn't work as is with iframes, because it assumes the context (here frame) should survive the reload, which is not true for iframes.

Comment 1

[Julian Descottes [:jdescottes]]

Let's just update the test to await and adjust the manifest accordingly.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 2028075 - [wdspec] Fix bidi reload/frame.py test_origin to await reload_and_assert

Comment 3

[Julian Descottes [:jdescottes]]

With this change, both Chrome and Firefox fail the test.

Chrome fails with:

FAIL test_origin[same_origin] - webdriver.bidi.error.UnknownErrorException: unknown error (navigation canceled by context disposal)
FAIL test_origin[cross_origin] - webdriver.bidi.error.UnknownErrorException: unknown error (Command can only be executed on top-level targets)

(this second error is odd as it seems to indicate Chrome rejects reload commands for non top-level contexts, which is not spec compliant)

Firefox fails with

FAIL test_origin[same_origin] - webdriver.bidi.error.UnknownErrorException: unknown error (Error: Browsing context got discarded)
FAIL test_origin[cross_origin] - webdriver.bidi.error.UnknownErrorException: unknown error (Error: Browsing context got discarded)

As described on Bug 2030909, this specific error seems related to the fact that we use the sessionHistory reload now. However switching back to context reload navigates to about:blank (so no error in the command itself, but fails the assert).

Comment 4

[Julian Descottes [:jdescottes]]

From what I mentioned in our triage meeting, we get a pytest warning about a non awaited coroutine:

RuntimeWarning: coroutine 'coroutine_name' was never awaited

Maybe we could make the tests fail on this warning?

On the linting side, Ruff implements something which seems relevant but I haven't tried it out https://github.com/astral-sh/ruff/pull/9911/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/66d3c7527fa6
https://hg.mozilla.org/integration/autoland/rev/383f8f4fc4a7
[wdspec] Fix bidi reload/frame.py test_origin to await reload_and_assert r=Sasha

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59353 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/383f8f4fc4a7

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot