Open Bug 2028186 Opened 2 months ago Updated 1 month ago

`createPrefSetter` in `NimbusGeckoUtils` is no longer nullable

Categories

(Firefox for Android :: Experimentation and Telemetry, task)

Product:
Firefox for Android
Component:
Experimentation and Telemetry
Platform:
All
Android
Type:
task

Tracking

()

People

(Reporter: olivia, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=kt])

Remove nullable ? off of fun createPrefSetter(geckoPrefState: GeckoPrefState, setType: BrowserPrefType?): SetBrowserPreference<*>? { in NimbusGeckoUtils.

Before one of the refactors, this function returned null instead of throw. It would be best to update that.

Changes needed:

  • The return type of this function should not be optional change SetBrowserPreference<*>? -> to SetBrowserPreference<*>
  • The test createPrefSetter with GeckoPrefState returns setter for various types in NimbusGeckoUtilsTest should have force unwrapping !! removed once the function is updated.
Mentor: ohall
Keywords: good-first-bug
Whiteboard: [lang=kt]
You need to log in before you can comment on or make changes to this bug.