Closed
Bug 2028233
Opened 7 months ago
Closed 7 months ago
Contextual search should not offer a config engine if user already has the addon or OpenSearch engine as default
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
151 Branch
People
(Reporter: mcheang, Assigned: mcheang)
References
()
Details
Attachments
(2 external files)
Contextual search should not offer a config engine if the user already has the addon or opensearch set as their default engine.
In this scenario, contextual search should instead offer the default engine which is the addon or open search.
| Assignee | ||
Updated•7 months ago
|
| Assignee | ||
Comment 1•7 months ago
|
||
Pushed by mcheang@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c87722bd9524
https://hg.mozilla.org/integration/autoland/rev/8b5ea4256104
Contextual search should not offer a config engine if user already has the addon or OpenSearch engine as default. r=Standard8,urlbar-reviewers
| Assignee | ||
Comment 3•7 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D291890
Updated•7 months ago
|
Attachment #9568881 -
Flags: approval-mozilla-beta?
Comment 4•7 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: If a user types the name of an already installed engine in the address bar, users would see a suggestion to search with a config engine with a similar name even when their preferred engine is already set via add-on or OpenSearch. Fixing this ensures we respect the user default engine and provide their default engine as a suggestion instead of the config engine.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: This is low risk because it only changes the contextual search suggestion, not the user’s actual default search settings. It ensures we suggest the user’s chosen engine (extension/OpenSearch) instead of a similar config engine.
The change is limited in scope, does not affect core search behavior, and simply reduces redundant or confusing suggestions.
- String changes made/needed?: No.
- Is Android affected?: no
Comment 5•7 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox151:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Updated•7 months ago
|
Attachment #9568881 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 months ago
|
status-firefox150:
--- → fixed
Updated•7 months ago
|
QA Whiteboard: [search] [qa-triage-done-c151/b150]
You need to log in
before you can comment on or make changes to this bug.
Description
•