Add "Access Connector" to brand ftl strings
Categories
(Enterprise Products :: Firefox, task)
Tracking
(Not tracked)
People
(Reporter: bsmth, Assigned: jporter)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
The Access Connector feature name shouldn't be localized. The convention is to use brand strings for copy that shouldn't be localized. e.g.;
Configurer un Access Connector pour...
Brand file:
Strings that reference the feature should use the { -brand-FEATURE-NAME } substitution, for example:
-policy-AccessConnector = Configure an access connector for proxying web traffic.
+policy-AccessConnector = Configure an { -brand-feature-access-connector } for proxying web traffic.
Updated•5 months ago
|
Comment 1•5 months ago
|
||
Comment 2•5 months ago
|
||
Brian, I'm not sure about this, there are other string that lives outside of brand file where it's also not to be localized. I'd prefer if we keep the brand.ftl really limited to actual branding items
| Reporter | ||
Comment 3•5 months ago
|
||
Thanks, Alex - I've no strong opinions where it should live (brand v enterprise), the goal is to make sure it doesn't get localized. Context is here -> https://github.com/mozilla-l10n/enterprise-firefox-l10n/pull/9#discussion_r2985798356
Comment 4•5 months ago
|
||
(In reply to Brian Thomas Smith [:bsmth] from comment #3)
Thanks, Alex - I've no strong opinions where it should live (
brandventerprise), the goal is to make sure it doesn't get localized. Context is here -> https://github.com/mozilla-l10n/enterprise-firefox-l10n/pull/9#discussion_r2985798356
Yes, and I commented there and flod as well and I think there's an agreement it should not be part of branding :), but I wanted to make sure the change of destination is captured here.
Comment 5•5 months ago
|
||
Authored by https://github.com/jporter-dev
https://github.com/mozilla/enterprise-firefox/commit/357a833387e173b1deb9027324f45a82f2c7f7a0
[enterprise-main] Bug 2028392 - Use brand strings for Access Connector feature name (#1010)
Description
•