2028442 - dom/tests/mochitest/pointerlock/test_pointerlock-api.html fails intermittently with the stencil navigation enabled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P1)

Description

[Tooru Fujisawa [:arai]]

from bug 2027803 comment #8

test_pointerlock-api.html fails intermittently at random timing.
The following fails after opening file_locksvgelement.html file, but other runs fail at some other points.

https://treeherder.mozilla.org/logviewer?job_id=557274299&repo=autoland&task=MX_bwbMjT76R43Gm8lZyNQ.0&lineNumber=18504

[task 2026-04-01T11:23:08.872+00:00] 11:23:08     INFO - Testing file_locksvgelement.html
[task 2026-04-01T11:23:08.873+00:00] 11:23:08     INFO - file_locksvgelement.html: Resetting fullscreen enter count.
[task 2026-04-01T11:23:08.873+00:00] 11:23:08     INFO - Buffered messages finished
[task 2026-04-01T11:23:08.874+00:00] 11:23:08     INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/pointerlock/test_pointerlock-api.html | Test timed out. - expected PASS

https://firefoxci.taskcluster-artifacts.net/VqNsdTIZR-ygVX13qxrToA/0/public/test_info/mozilla-test-fail-screenshot_cnvnvlg3.png

https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C24.04%2Cdebug%2Cmochitests%2Cwith%2Chttp2%2Cserver%2Ctest-linux2404-64%2Fdebug-mochitest-plain-http2%2C5&tochange=a4329fcafa2d402060c1f70a716130e6722d7b47&fromchange=e11cf0b138f0b47a7a6fcf0e74c694260e76ddf0

Comment 1

[Tooru Fujisawa [:arai]]

The test is known to fail on many configuration.

https://searchfox.org/firefox-main/rev/65f89c383b216d3b4f210657c9af12a32048fb67/dom/tests/mochitest/pointerlock/mochitest.toml#10,34-40

["test_pointerlock-api.html"]
...
skip-if = [
  "os == 'win' && os_version == '11.26200'", # Bug 2019745
  "opt", # Bug 1833142
  "os == 'android'", # Bug 1612553
  "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'", # Bug 1857057
  "os == 'mac' && os_version == '14.70' && arch == 'x86_64' && debug", # Bug 1886190
]

This time it starts failing on debug config, after enabling a pref to make things faster,
and there's already a condition to skip it on "opt".

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 2028442 - Skip test_pointerlock-api.html on all configurations. r?smaug!

This test is known to intermittently fail on various configuration,
and enabling the stencil navigation in bug 2027803 increases the frequency.
The test has already been marked as skip on opt build, which means this test
fails if things work quickly, and indeed the test has several timing dependent
things, such as setTimeout etc, for stabilizing purpose.
The test should be rewritten to use more stable and reliable way.

Comment 3

[Tooru Fujisawa [:arai]]

The testcase contains timing dependent things, such as the following:

https://searchfox.org/firefox-main/rev/65f89c383b216d3b4f210657c9af12a32048fb67/dom/tests/mochitest/pointerlock/test_pointerlock-api.html#81-83

// Try to stabilize the state before running the next test.
SimpleTest.waitForFocus(
  () => requestAnimationFrame(() => setTimeout(runNextTest)));

And also some indirection to override the testing functions, in pointerlock_utils.js etc.

The test should be rewritten, to use non-timing dependent thing with clearer architecture.

Comment 4

[Tooru Fujisawa [:arai]]

there's bug 1886190 for the intermittent failure.
and there's indeed failures on debug, tsan, asan, and ccov.
added with "opt" above, all configuration are known to fail intermittently or permanently.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77755db878aa
https://hg.mozilla.org/integration/autoland/rev/2d02b68f203b
Skip test_pointerlock-api.html on all configurations. r=smaug

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2d02b68f203b

Comment 7

[BMO Github Automation]

Authored by https://github.com/arai-a
https://github.com/mozilla/enterprise-firefox/commit/77755db878aafc8120147e136b1d7551c5bd7d77
[enterprise-main] Bug 2028442 - Skip test_pointerlock-api.html on all configurations. r=smaug