Closed Bug 2028819 Opened 2 months ago Closed 2 months ago

Usage infobars do not stay dismissed after relog

Categories

(Firefox :: IP Protection, defect)

Firefox 150
Desktop
Windows 11
defect

Tracking

()

VERIFIED FIXED
151 Branch
Tracking Status
firefox150 --- verified
firefox151 --- verified

People

(Reporter: vvalentina, Assigned: rking)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fx-vpn])

Attachments

(3 files)

[Affected versions]:

  • Firefox Beta 150.ob4;

[Affected Platforms]:

  • desktop;

[Prerequisites]:

  • Have the VPN available;
  • Be logged in with an account that has 75/90% usage and the warning and infobars available;

[Steps to reproduce]:

  1. Close the infobar;
  2. Relog;
  3. Observe the infobar;

[Expected result]:
The infobar is not displayed after relog, as it was removed before.

[Actual result]:
The infobar is re-displayed.

The issue also applies if the infobar is dismissed from the "X" button -> at turn ON it is shown again.

Assignee: nobody → rking
Attachment #9568327 - Attachment description: Bug 2028819 - Usafe infobars do not stay dismissed - r=#ip-protection-reviewers → Bug 2028819 - Usage infobars do not stay dismissed - r=#ip-protection-reviewers
Attachment #9568861 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Infobar warning shows repeatedly when usage data is refreshed even after the user dismisses it
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: N/A
  • Risk associated with taking this patch: low
  • Explanation of risk level: Adds new pref to remember the infobar being dismissed, not a far reaching fix
  • String changes made/needed?: None
  • Is Android affected?: no
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Attachment #9568861 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified this using Firefox Beta 150.0b9 on macOS 26.
The usage infobar does not appear after dismissal at relog on the same profile, no matter if was dimissed in main window and a separate one.

What should happen while using an account that had the infobar dimissed, on a different PC or Firefox version? Should we show the infobar?

Status: RESOLVED → VERIFIED

The infobar should stay dismissed if the user has seen and dismissed it, even if they log in elsewhere. The dismissal is tracked with the browser.ipProtection.bandwidthWarningDismissedThreshold pref.

The "browser.ipProtection.bandwidthWarningDismissedThreshold" pref has the value "0" while logging in on a new profile with an account that had the infobar previously dimissed.

Flags: needinfo?(rking)

As discussed on slack, I think if sync is on, this should work as expected, and with sync off and a brand new profile, it is reasonable that the warning comes back because all prefs are reset on login to a new profile.

Flags: needinfo?(rking)

This is the same while having Sync ON or OFF - with sync ON and a brand new profile the infobar comes back.
Considering the "browser.ipProtection.enabled" pref is "true" while using a VPN enrolled account on a new profile and sync ON, shouldn't this be the same for the "browser.ipProtection.bandwidthWarningDismissedThreshold"?

Flags: needinfo?(rking)

Hm, I would expect the same behavior for any pref, although it could be that the new account is enrolled in the rollout that flips the pref rather than being carried over from being flipped on a previous account. Can you confirm whether other prefs carry over? For example browser.ipProtection.everOpenedPanel

Flags: needinfo?(rking)
Flags: needinfo?(vvirlics)

Using the same account, with the infobar dimissed and Sync ON, to log in on a new profile, we noticed that the "browser.ipProtection.everOpenedPanel" value is not caried over, as it has the "false" value.

Flags: needinfo?(vvirlics) → needinfo?(rking)

Given that other prefs don't carry over to a new profile, I think we can accept that the dismissal won't carry over. I think it'd be too large of a lift to find another way to remember that the warnings were dismissed, and a user on a new profile could expect a number of differences in behavior without their old prefs set.

Flags: needinfo?(rking)
Whiteboard: [fx-vpn]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: