2028843 - [HDR] Combine the various prefs that enable HDR video and add a force_enabled pref for testing on non-HDR displays (especially useful for reftests probably)

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, enhancement, P2)

Description

[Ashley Hale [:ahale]]

This could be useful for testing/debugging, and reftests could use it to verify behavior of the code paths without an HDR display in the test environment.

Comment 1

[Ashley Hale [:ahale]]

Attachment: Bug 2028843 - Combine several HDR prefs and add a force_enabled pref r?#gfx-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba37d504631a
https://hg.mozilla.org/integration/autoland/rev/7fa3007cdb16
Combine several HDR prefs and add a force_enabled pref r=gfx-reviewers,bradwerth

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7fa3007cdb16

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This change lets users work around bugs in HDR video playback if necessary, and is useful for troubleshooting.

Fixes a minor issue where moving a window between monitors might change between HDR and non-HDR display of a video unpredictably as it was making the decision on displaying as HDR in two separate places, which could make different decisions if a window is moved between displays after the video starts.

• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Shouldn't be visible, the only case that could be tested is opening an HDR video file (not YouTube as that checks video-dynamic-range first) where it would now be displayed with the correct HDR range. We are already organizing some testing for this feature.
• Risk associated with taking this patch: low
• Explanation of risk level: Mostly this consolidates prefs to make troubleshooting easier, but it also makes a change where we no longer check twice if the display is HDR when displaying HDR video, if that has consequences we'd like to know in testing of the beta.
• String changes made/needed?: None
• Is Android affected?: no

Comment 5

[Ashley Hale [:ahale]]

Attachment: Bug 2028843 - Combine several HDR prefs and add a force_enabled pref

We have quite a collection of prefs that enable HDR video, let's reduce
that to gfx.color_management.hdr and add a pref called
gfx.color_management.hdr.force_enabled for testing HDR rendering code
paths without an HDR display

Original Revision: https://phabricator.services.mozilla.com/D294830

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2f5befed701d
https://hg.mozilla.org/releases/mozilla-beta/rev/256b14711901