Closed Bug 2029006 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 58950 - streamHTML with an invalid Sanitizer config should throw.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 58950 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58950
Details from upstream follow.

Daniel Vogelheim <vogelheim@chromium.org> wrote:

streamHTML with an invalid Sanitizer config should throw.

The current code might swallow an exception thrown from the Sanitizer
constructor, which leads to streaming being unsanitized. Instead,
the streamHTML call (& friends) should pass on the exception.

Fixed: 497655906
Change-Id: I6ad8a2ae7bcc5611c536c1a74f6f036926431712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7725441
Reviewed-by: Noam Rosenthal \<nrosenthal@google.com>
Commit-Queue: Daniel Vogelheim \<vogelheim@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609225}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 21 tests and 60 subtests ## Status Summary ### Firefox `OK` : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] `PASS`: 12[GitHub] 27[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] `FAIL`: 192[GitHub] 807[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `OK` : 1 `PASS`: 180 `FAIL`: 24 ### Safari `OK` : 1 `PASS`: 12 `FAIL`: 192 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dbe341d7374bb497e5b12f9c597f4bca670f10d) [GitHub PR Head](https://wpt.fyi/results/?sha=735817b8e7dec1d9e4c7dc715a291528182d2da0&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=735817b8e7dec1d9e4c7dc715a291528182d2da0&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/73576f711157 https://hg.mozilla.org/integration/autoland/rev/6ade12d985ba [wpt PR 58950] - streamHTML with an invalid Sanitizer config should throw., a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: