2029011 - [wpt-sync] Sync PR 58947 - Implement rect() and xywh() shapes in shape-outside

Status: RESOLVED FIXED

(Core :: Layout: Floats, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 58947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58947
Details from upstream follow.

Jason Leo <[e-mail]> wrote:

Implement rect() and xywh() shapes in shape-outside

Enable the rect() and xywh() CSS basic shape functions for the
shape-outside property, gated behind the new
CSSShapeOutsideRectAndXywhSupport runtime feature flag.

The parsing, CSS value, style conversion, and layout infrastructure
for rect() and xywh() already exists (used by clip-path). Both
functions are internally converted to BasicShapeInset, which
shape-outside layout already handles. The only change needed is
allowing the parser to accept these functions for shape-outside
when the flag is enabled.

Remove fail-baseline -expected.txt files for existing WPT tests
that now pass with the experimental flag enabled. Add
float-retry-push reftests for rect() and xywh() verifying layout
behavior matches the equivalent inset() shape.

ChromeStatusEntry: https://chromestatus.com/feature/6323071520735232

Bug: 490343453
Change-Id: Ieb34167383addc82d355f5b7b1ab5536c8246182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7725306
Commit-Queue: Jason Leo \<[e-mail]>
Reviewed-by: Fredrik Söderquist \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1609282}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=694e8f65d0b8cf51a4ad9beebdabc3fb8b2f77f0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

PASS: 2[GitHub] 7[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

FAIL: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b465b6bb0b5
https://hg.mozilla.org/integration/autoland/rev/39909c3af541
[wpt PR 58947] - Implement rect() and xywh() shapes in shape-outside, a=testonly

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/39909c3af541