Closed Bug 2029019 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 58876 - Make sure we traverse all direct children for kMarkReattach

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58876 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58876
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Make sure we traverse all direct children for kMarkReattach

kMarkReattach is used to resume box tree re-attachment for size
container children, even if they don't need style recalc, for
interleaved style recalcs.

TraverseChildren() returned true because the ChildNeedsStyleRecalc()
returned true, but not TraverseChild() for each child since they were
all clean. kMarkReattach is set for one level (direct children of a size
container whose style recalc has been resumed) and will be cleared for
any descendants.

Bug: 494601107
Change-Id: If1336dd84c6bc1d4efdd35066a6a3f0020182f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7714662
Reviewed-by: Steinar H Gunderson \<sesse@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607860}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 296 tests and 2 subtests

Status Summary

Firefox

OK : 187
PASS: 1[GitHub] 61[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 1159[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 1197[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 1198[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 1205[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
FAIL: 254[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 255[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 262[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt] 263[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: REOPENED → RESOLVED
Closed: 3 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.