2029072 - Using `moz-phab uplift --assessment-id` shouldn't require extra browser clicks

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Connor Sheehan [:sheehan]]

Currently when passing moz-phab uplift --assessment-id, we use the assessment ID only to build a URL which we print out and request the user visit. Once on the page, the user must "save" their assessment form, which is confusing and requires extra developer interaction.

Now that bug 2013374 has landed, we should be able to use moz-phab's Phabricator API token to authenticate with Lando and link the assessment form to the newly created revision - no extra clicks or interaction required.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: uplift: use Lando's Phab API key auth to link assessment (Bug 2029072) r?shtrom,zeid

Use the new uplift assessment linking API endpoint to
link newly created revisions to assessments when the
--assessment-id argument is used. The assessment
ID was previously used to print a URL for the user
to visit. We now only build that URL when --assessment-id
was not used, or when the API-based linking fails.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] uplift: add API endpoint to link revisions to assessments (Bug 2029072) (#1064)

Comment 3

[BMO Github Automation]

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/lando/commit/a75881f6a498aea2f88bac9d4e66cd1fcb8a13e9
[main] uplift: add API endpoint to link revisions to assessments (Bug 2029072) r=shtrom,zeid

Comment 4

[BMO Github Automation]

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/review/commit/c27560f6667f0cff469922d728e8054960242a16
[main] uplift: use Lando's Phab API key auth to link assessment (Bug 2029072) r=shtrom,zeid