2029092 - Add exhaustive test coverage for tabs.move() and split views

Status: RESOLVED FIXED

(WebExtensions :: Frontend, task, P2)

Description

[Rob Wu [:robwu]]

We have some tabs.move() tests involving split views in browser_ext_tabs_splitViewId.js, which does some spot checks around boundary conditions that were expected to potentially be more sensitive to bugs.

Bug 2027855 shows that a bug prevented tabs.move() from moving split views, due to the implementation only working for the last tab only. The existing test coverage test incidentally tested this scenario as part of the "move tab forward" test, but that proved insufficient as it did not cover the non-final-tab cases. The purpose of this bug is to have comprehensive test coverage that checks the behavior of moving a split view (or tabs within) all across the tab strip.

Given the many test cases, I'm going to reuse the pattern of setting up and moving tabs from browser_ext_tabGroups_move that I introduced to also (exhaustively) test the tabGroups.move API (but other than the structure and some shared setup, the file differs significantly). That results in more compact (and readable) test cases than browser_ext_tabs_splitViewId.js.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2029092 - Add more tests for tabs.move() and split views

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f24c57cf05f5
https://hg.mozilla.org/integration/autoland/rev/018e3c01ab26
Add more tests for tabs.move() and split views r=rpl

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/018e3c01ab26