2029099 - tabs.group() does not work with split views

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Rob Wu [:robwu]]

tab.group() does not work with split views. It may separate split views, or fail outright with "An unexpected error occurred".

Originally reported at https://github.com/piroor/treestyletab/issues/3806#issuecomment-4115398870

I've realized that browser.tabs.group() cannot create new group with split view (on Nightly 151.0a1). For example, assume there are tabs:

• tab#10(splitViewId=1)
• tab#11(splitViewId=1)
• tab#12(splitViewId=-1)

Results:

• browser.tabs.group({ tabIds: [10, 11, 12], createProperties: { windowId: 1 } }) => unexpected error
• browser.tabs.group({ tabIds: [10, 11], createProperties: { windowId: 1 } }) => unexpected error
• browser.tabs.group({ tabIds: [11, 12], createProperties: { windowId: 1 } }) => unexpected error
• browser.tabs.group({ tabIds: [12], createProperties: { windowId: 1 } }) => success

I successfully add split view tabs to an existing group, but Firefox automatically separate split tabs.

• browser.tabs.group({ tabIds: [10, 11], groupId: 1 }) => success, but tab#10 and tab#11 become regular tabs.
• browser.tabs.group({ tabIds: [10], groupId: 1 }) => success, but only tab#10 is grouped, and both tab#10 and tab#11 become regular tabs.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 2029099 - Fix tabs.group() and ungroup() with split views

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7743f03b113
https://hg.mozilla.org/integration/autoland/rev/3dcfe4fcad49
Fix tabs.group() and ungroup() with split views r=rpl

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/3dcfe4fcad49

Comment 4

[rbloor]

Documentation updates available in Release 151 split-view tab group and move fixes #43821