Closed Bug 2029257 Opened 4 months ago Closed 3 months ago

Add “Report issues” link to disclaimer

Categories

(Core :: Machine Learning: Frontend, task, P1)

task

Tracking

()

VERIFIED FIXED
151 Branch
Iteration:
151.2 - April 6 - April 17
Tracking Status
firefox150 + verified
firefox151 --- verified

People

(Reporter: jlevinsohn, Assigned: dmosedale)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [genai])

Attachments

(2 files)

Update the disclaimer text at the bottom of Smart Window to include a “Report issues” link.

[Tracking Requested - why for this release]: clearer feedback mechanism for mvp (english-only strings)

Assignee: nobody → dmosedale
Iteration: --- → 151.2 - April 6 - April 17
Priority: -- → P1

we don't usually take string uplifts for beta, but if you do plan on requesting uplift, pls ping l10n team

Flags: needinfo?(dmosedale)

I've reached out to the l10n team and asked them to confirm my guess that uplifting should be fine, because SmartWindow is (for now) English only and the string is in browser/locales-preview.

Flags: needinfo?(dmosedale)

These strings are in preview and not exposed to localization, so no concerns from l10n team for this uplift.

After discussion with Product & Design, the updated URL will be the currently hidden https://connect.mozilla.org/t5/discussions/smart-window-beta-feedback/td-p/122365. I don't have privs to update comment 0 here, but I'll update Jira and the patch.

Pushed by dmosedale@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e4fe9c4deb1e https://hg.mozilla.org/integration/autoland/rev/96d21f2bd40a add "report issues" link to SmartWindow disclaimer, r=ai-frontend-reviewers,fluent-reviewers,desktop-theme-reviewers,Mardak,flod,tgiles
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

Before we request uplift, I think it's important to know the answer to the authentication/signup question I’ve asked towards the end of this Slack thread.

TL;DR: If someone responds in thread and an engineer can be recruited to quickly request uplift using Lando before 6am Pacific Friday, we might conceivably get it in Beta 8 (I've already tested the patch rebased against 151 beta locally by hand). If not, I’m hoping we can still land it for Beta 9 (which spins on Monday).

Loren and :Jon S re-verified overnight that the Mozilla Connect URL behaves correctly when switched into production mode. Beta 8 has already been built. I'll request uplift shortly for beta 9 (which spins on Monday).

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: A key function of the SmartWindow MVP is to collect user feedback. The addition of this link adds a low-friction way to collect that feedback.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: I don't think it's critical that we do a manual QE test after landing because of the low risk, but there's some value in doing another check.

How to test:

  • Open a new tab in smart window

  • Start a chat by typing a question in smartbar and clicking "Ask"

  • Look for the “Report any issues” link below the smartbar

  • Click it

  • Expect to see an Auth0 page because the production thread is temporarily hidden

  • Notice that the chat has shifted over to the sidebar

  • Click “Report any issues” again, this time from the sidebar to verify the click mechanism works from there

  • Expect to see another new tab next to the first, also with the Auth0 page

  • Risk associated with taking this patch: low

  • Explanation of risk level: UX (low):

  • Adds a link to the text disclaimer at the bottom of a running chat session (main tab or sidebar)

  • Link opens a thread on connect.mozilla.org in a new tab (currently hidden behind authentication, which will be removed and re-checked before launch)

Engineering (low):

  • CSS changes only apply to newly added link.
  • Code changes small & straightforward.

Q/A (low)

  • Automated testing of
    • link existence in page
    • correct link URL
    • use of new-tab when opened
  • Manually tested in
    • Nightly 151 on Windows 11 and MacOS 26.4.
    • locally built Beta 150 on MacOS 26.4.
  • No platform-specific-code touched.
  • String changes made/needed?: The only string changed by this patch is not exposed to localizers because SmartWindow strings are all in browser/locales-preview. https://bugzilla.mozilla.org/show_bug.cgi?id=2029257#c5 has l10n approval.
  • Is Android affected?: no
Attachment #9568878 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Attachment #9568878 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [uplift][qa-ver-needed-c151/b150]

Verified as fixed this issue wiht the steps from comment 11 on latest Nightly 151.0a1 and Beta 150.0b9 under Win 11, macOS 26 and Ubuntu 26.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c151/b150] → [uplift][qa-ver-done-c151/b150]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: