2029352 - Pass in SerialPlatformService to SerialManager

Status: RESOLVED FIXED

(Core :: DOM: Web Serial, task, P3)

Description

[Greg Stoll :gstoll]

See this comment - this would clean up our error handling if the SerialPlatformService doesn't exist.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cmartin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

Attachment: Bug 2029352 - cache SerialPlatformService in SerialManagerParent r=cmartin!

I looked into passing the SerialPlatformService into the SerialManagerParent,
but this is a bit awkward because the constructor can't return an error. But I
did cache the SerialPlatformService in SerialManagerParent::Init() and removed
several now unneeded null checks elsewhere.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1559e2cfa2e
https://hg.mozilla.org/integration/autoland/rev/6962052cd7ee
cache SerialPlatformService in SerialManagerParent r=cmartin

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6962052cd7ee