Closed Bug 2029362 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 58974 - Make filterable select and customizable combobox scroll with arrow keys

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58974
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Make filterable select and customizable combobox scroll with arrow keys

When using arrow keys to move the active option forwards or backwards,
the newly active option should be scrolled into view, just like using
tab and shift+tab to focus elements scrolls them into view.

Bug: 453705243
Change-Id: I4cdd813b0a65f5fd463836aa69fe6da1122c7582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7727182
Reviewed-by: David Baron \<dbaron@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609792}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

OK : 2[GitHub] 6[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 6[GitHub] 13[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 15[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 2
FAIL: 6

Safari

OK : 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.