[wpt-sync] Sync PR 58974 - Make filterable select and customizable combobox scroll with arrow keys
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 58974 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/58974
Details from upstream follow.
Joey Arhar <jarhar@chromium.org> wrote:
Make filterable select and customizable combobox scroll with arrow keys
When using arrow keys to move the active option forwards or backwards,
the newly active option should be scrolled into view, just like using
tab and shift+tab to focus elements scrolls them into view.Bug: 453705243
Change-Id: I4cdd813b0a65f5fd463836aa69fe6da1122c7582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7727182
Reviewed-by: David Baron \<dbaron@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609792}
| Assignee | ||
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
| Assignee | ||
Comment 2•3 months ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 8 tests
Status Summary
Firefox
OK : 2[GitHub] 6[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 6[GitHub] 13[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 15[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
Chrome
OK : 2
FAIL: 6
Safari
OK : 2
FAIL: 6
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/semantics/forms/customizable-combobox/active-option-pseudo.tentative.html [wpt.fyi]
- When the datalist opens, the first option should match :active-option.:
FAIL - Disabled options should not match :active-option.:
FAIL
- When the datalist opens, the first option should match :active-option.:
- /html/semantics/forms/customizable-combobox/customizable-combobox-filtered-pseudo.tentative.html [wpt.fyi]
- Customizable combobox option:filtered behavior:
FAIL - Case folding:
FAIL
- Customizable combobox option:filtered behavior:
- /html/semantics/forms/customizable-combobox/customizable-combobox-keyboard-behavior.tentative.html [wpt.fyi]
- Keyboard behavior for customizable combobox.:
FAIL(Chrome:FAIL, Safari:FAIL) - Options should be scrolled into view when arrowed to.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Keyboard behavior for customizable combobox.:
- /html/semantics/forms/customizable-combobox/datalist-popover.tentative.html [wpt.fyi]
- Focusing input should show datalist as a popover.:
FAIL
- Focusing input should show datalist as a popover.:
- /html/semantics/forms/the-select-element/filterable-select/filterable-select-filtered-pseudo.tentative.html [wpt.fyi]
- Filterable select option:filtered behavior:
FAIL - Case folding:
FAIL
- Filterable select option:filtered behavior:
- /html/semantics/forms/the-select-element/filterable-select/filterable-select-keyboard-behavior.tentative.html [wpt.fyi]
- appearance base-select: Keyboard behavior for filterable select.:
FAIL(Chrome:FAIL, Safari:FAIL) - appearance base-select: active option should get scrolled into view.:
FAIL(Chrome:FAIL, Safari:FAIL) - appearance auto: Keyboard behavior for filterable select.:
FAIL(Chrome:FAIL, Safari:FAIL) - appearance auto: active option should get scrolled into view.:
FAIL(Chrome:FAIL, Safari:FAIL)
- appearance base-select: Keyboard behavior for filterable select.:
- /html/semantics/forms/customizable-combobox/customizable-combobox-appearance.html [wpt.fyi]:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-24h2-debug,Gecko-windows11-64-24h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /html/semantics/forms/the-select-element/filterable-select/filterable-select-appearance.html [wpt.fyi]:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-24h2-debug,Gecko-windows11-64-24h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview]
Tests Disabled in Gecko Infrastructure
- /html/semantics/forms/customizable-combobox/customizable-combobox-appearance.html [wpt.fyi]:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-24h2-debug,Gecko-windows11-64-24h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview] - /html/semantics/forms/the-select-element/filterable-select/filterable-select-appearance.html [wpt.fyi]:
FAIL[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-24h2-debug,Gecko-windows11-64-24h2-opt],SKIP[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview]
https://hg.mozilla.org/mozilla-central/rev/bff0e7c55e4a
https://hg.mozilla.org/mozilla-central/rev/d2fbc2285e9b
Description
•