Closed Bug 2029367 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 58613 - Snapshot post-layout for all but scroll-timelines

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58613 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58613
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Snapshot post-layout for all but scroll-timelines

'Run snapshot post-layout state steps' was introduced in the CSSOM View
spec[1] to formalize when state for scroll-state() queries, anchor
position effects based on scrolling, and scroll-timeline progress is
updated.

There is a pull request[2] to tell when to invoke snapshotting from the
HTML event loop. This CL aligns snapshotting with that CL for all
snapshotting except for scroll-timelines.

scroll-timeline-multi-pass.tentative.html is updated to align with the
one-snapshot-per-resizeObserver-loop-iteration in the HTML spec PR. The
difference between scroll-timelines and other snapshotting is that the
scroll-timelines are still snapshotted before the first style/layout
update in the resizeObserver loop.

The reason we keep the pre-layout snapshotting of scroll-timelines for
now is that timleines are only progressed before the first style/layout
update, which means the post-layout snapshotting will always cause
scroll-timelines to be a frame late (with the exception of the first
frame) unless we start allowing scroll-timelines to progress in the
resizeObserver loop.

[1] https://drafts.csswg.org/cssom-view/#run-snapshot-post-layout-state-steps
[2] https://github.com/whatwg/html/pull/11613

Bug: 384523570
Change-Id: Iabb35fd06e5a2b9a95a09a25d27d7baad545653f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7673480
Reviewed-by: Robert Flack \<flackr@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1601971}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 100 tests

Status Summary

Firefox

OK : 1[GitHub] 78[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 79[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
PASS: 553[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 561[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 565[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 1[GitHub] 144[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 151[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 152[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/73ac64842774 https://hg.mozilla.org/integration/autoland/rev/7caf9b209730 [wpt PR 58613] - Snapshot post-layout for all but scroll-timelines, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7caf9b209730

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.