Closed Bug 2029370 Opened 3 months ago Closed 2 months ago

[wpt-sync] Sync PR 58982 - Remove border-color: gray from UA stylesheet for <table>

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58982 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58982
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Remove border-color: gray from UA stylesheet for <table>

**** GARDENERS! ****
If this change causes a failure or two on the CI, please do me
a huge favor and simply mark the offending tests disabled or
failing, and assign me a bug. I'll take care of cleaning it up.
It's a pain to get such a large CL landed. Thanks in advance.

The spec does not contain this rule:

https://html.spec.whatwg.org/multipage/rendering.html#tables-2

and it causes the borders to incorrectly not default to
currentColor.

This patch implements the change behind the
TableDefaultBorderColorCurrentColor flag, which is experimental
for now. I will need to send an I2S for this change before shipping
it, because of the observable change.

Bug: 494554835
Change-Id: I16881309334193d091c6e0f9b6c6580f05fa3ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7708734
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609982}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 37 tests and 1 subtests

Status Summary

Firefox

OK : 1[GitHub] 10[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 1[GitHub] 66[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 89[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 92[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 30[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 31[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/rendering/non-replaced-elements/tables/table-border-presentational-hints-ascii-case-insensitive.html [wpt.fyi]: FAIL
  • /html/rendering/non-replaced-elements/tables/hidden-attr.html [wpt.fyi]
    • Computed display and visibility of colgroup: FAIL
    • Computed display and visibility of col: FAIL
    • Computed display and visibility of thead: FAIL
    • Computed display and visibility of tbody: FAIL
    • Computed display and visibility of tfoot: FAIL
    • Computed display and visibility of tr: FAIL
  • /html/rendering/non-replaced-elements/tables/table-attribute.html [wpt.fyi]
    • table thead align attribute center is correct: FAIL
    • table thead align attribute middle is correct: FAIL
    • table thead align attribute left is correct: FAIL
    • table thead align attribute right is correct: FAIL
    • table tbody align attribute center is correct: FAIL
    • table tbody align attribute middle is correct: FAIL
    • table tbody align attribute left is correct: FAIL
    • table tbody align attribute right is correct: FAIL
    • table tfoot align attribute center is correct: FAIL
    • table tfoot align attribute middle is correct: FAIL
    • table tfoot align attribute left is correct: FAIL
    • table tfoot align attribute right is correct: FAIL
    • table tr align attribute center is correct: FAIL
    • table tr align attribute middle is correct: FAIL
    • table tr align attribute left is correct: FAIL
    • table tr align attribute right is correct: FAIL
    • table td align attribute center is correct: FAIL
    • table td align attribute middle is correct: FAIL
    • table td align attribute left is correct: FAIL
    • table td align attribute right is correct: FAIL
    • table th align attribute center is correct: FAIL
    • table th align attribute middle is correct: FAIL
    • table th align attribute left is correct: FAIL
    • table th align attribute right is correct: FAIL
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/72481a226ca7 https://hg.mozilla.org/integration/autoland/rev/d9244c2aa53b [wpt PR 58982] - Remove border-color: gray from UA stylesheet for <table>, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d9244c2aa53b

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.