2029378 - Datepicker dialog causes Firefox canvas to go off screen on "notch" phones

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[contact]

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:150.0) Gecko/150.0 Firefox/150.0

Steps to reproduce:

Use an html date field to open the DatePicker dialog.

Actual results:

Observe that, as the DatePicker opens, the webpage canvas will be pushed under the Android statusbar, and the Firefox toolbar intrudes on the Android navbar.

Upon hiding the DatePicker dialog the top of the webpage remains inaccessible and behind the Android statusbar.

Expected results:

The DatePicker does not break the Firefox UI, just as it didn't in previous versions.

Comment 1

[Moyin [:moyin]]

Hello,

Thank you for reporting this issue.

Please can you share the website this happens on so we can try to reproduce it?

Thank you.

Comment 2

[contact]

Hello Moyin,

I believe the most accessible to you would be to visit the date input Mozilla doc.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/date#try_it

Clicking on the render example will open the Android Date Picker modal and triggers the issue on my Pixel device.

Comment 3

[Moyin [:moyin]]

Thanks for sharing the link, I was able to reproduce it.

Comment 4

[Moyin [:moyin]]

Hey Titouan, please can you take a look at this? Is this related to the edge to edge feature?

Comment 5

[Titouan Thibaud [:titouan]]

Redirecting to Petru as this is not related to Edge2Edge background but rather on broader Edge to Edge on Fenix.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2029378 - Avoid updating the e2e strategy when navigating to fragments with a DialogFragment parent r=#android-reviewers

Comment 7

[Petru-Mugurel Lingurar [:petru]]

If the fix is good it should probably be uplifted to 150.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4cbc026d8625
https://hg.mozilla.org/integration/autoland/rev/815ee7d40ef8
Avoid updating the e2e strategy when navigating to fragments with a DialogFragment parent r=android-reviewers,tthibaud

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/815ee7d40ef8

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Edge to edge UI related glitches
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2027911#c0
  https://bugzilla.mozilla.org/show_bug.cgi?id=2029378#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small change, verified by QA / eng.
• String changes made/needed?: --
• Is Android affected?: yes

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2029378 - Avoid updating the e2e strategy when navigating to fragments with a DialogFragment parent

Original Revision: https://phabricator.services.mozilla.com/D295817

Comment 13

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Edge to edge UI related glitches
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2027911#c0
  https://bugzilla.mozilla.org/show_bug.cgi?id=2029378#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small change, verified by QA / eng.
• String changes made/needed?: --
• Is Android affected?: yes

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2029378 - Avoid updating the e2e strategy when navigating to fragments with a DialogFragment parent

Original Revision: https://phabricator.services.mozilla.com/D295817

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/39aa8def758e
https://hg.mozilla.org/releases/mozilla-beta/rev/f764222a059e

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/23a5fff8738e
https://hg.mozilla.org/releases/mozilla-release/rev/c44ff0083456

Comment 17

[Mira Lobontiu (Android QA)]

Attachment: 2029378.jpg

Verified as fixed on the latest Firefox for Android Nightly 152.0a1 from 4/27, Beta 151.0b3, and RC 150.0.1.
Tested with a Pixel 6 (Android 17), and a Samsung Galaxy s24 (Android 16).
On both devices, the issue was reproducible.