Closed Bug 2029514 Opened 3 months ago Closed 18 hours ago

change full screen icon in zoom sidebar for RTL languages

Categories

(Firefox :: Sidebar, enhancement)

Firefox 149
enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: uneasy_latitude544, Assigned: chimaifeanyi29)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:149.0) Gecko/20100101 Firefox/149.0

Steps to reproduce:

switch to arabic language
click on burger menu

Actual results:

the fullscreen icon is like LTE language

Expected results:

reverse the fullscreen icon so it fits RTL languages.

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Sidebar
Assignee: nobody → chimaifeanyi29
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:chimaifeanyi29, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(sfoster)
Flags: needinfo?(chimaifeanyi29)

I queued it to land

Flags: needinfo?(sfoster)
Flags: needinfo?(chimaifeanyi29)
Pushed by sfoster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/88735f8a31c3 https://hg.mozilla.org/integration/autoland/rev/f6c5dcd700a0 Flip fullscreen icon in zoom controls for RTL languages. r=sfoster,desktop-theme-reviewers.
Status: ASSIGNED → RESOLVED
Closed: 18 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: