2029949 - Consider returning a hint directly in StyleChangeKind

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Haven't dug yet but at a glance it seems more provably correct (since multiple of those changes might happen at a time) and maybe less confusing?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2029949 - Fix children hint computation for style queries. r=diegociudadreale,#style

We can't just early-return CASCADE_SELF now, it's not sound in presence
of container queries if the custom properties or container-name changes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b655a605eb33
https://hg.mozilla.org/integration/autoland/rev/a333985c4f99
Fix children hint computation for style queries. r=diegociudadreale

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07e27bfce5ac
https://hg.mozilla.org/integration/autoland/rev/12a1ea4146eb
Fix explicit inheritance of custom props, and annotate a failure that fails for non-custom props already.

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/a333985c4f99
https://hg.mozilla.org/mozilla-central/rev/12a1ea4146eb

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59101 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot