Closed Bug 2030016 Opened 1 month ago Closed 1 month ago

Unified search button became darker

Categories

(Toolkit :: Themes, defect)

Firefox 151
defect

Tracking

()

VERIFIED FIXED
151 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox149 --- unaffected
firefox150 --- unaffected
firefox151 --- verified
firefox152 --- verified

People

(Reporter: mbeier, Assigned: oarnesto)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [recomp][acorntractors])

Attachments

(2 files)

Attached image Screenshot.png

STR:

  1. Enable dark mode
  2. Make sure urlbar is not focused and unified search button is visible
  3. Focus urlbar

Expected: Unified search button becomes lighter
Actual: Unified search button becomes darker

I suspect this is because --urlbar-box-focus-bgcolor was renamed to --urlbar-box-background-color-focus and the definition for light mode was moved to urlbar.css but the definiton for dark mode wasn't. Since urlbar.css is loaded last, the light mode definition overrides the definition for dark mode.

Set release status flags based on info from the regressing bug 2008598

:oarnesto, since you are the author of the regressor, bug 2008598, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(oarnesto)
Whiteboard: [recomp][acorntractors]

:mbeier has the right of it, assigning it to myself.

Assignee: nobody → oarnesto
Severity: -- → S4
Status: NEW → ASSIGNED
Flags: needinfo?(oarnesto)
Attachment #9567409 - Attachment description: WIP: Bug 2030016 - Correct unified search button color on dark mode r=#reusable-components-reviewers-rotation → WIP: Bug 2030016 - Correct unified search button color on dark mode r=#urlbar-reviewers
Attachment #9567409 - Attachment description: WIP: Bug 2030016 - Correct unified search button color on dark mode r=#urlbar-reviewers → Bug 2030016 - Correct unified search button color on dark mode r=#urlbar-reviewers
Pushed by oarnesto@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/22635e263d07 https://hg.mozilla.org/integration/autoland/rev/e9a9a2fe5037 Correct unified search button color on dark mode r=urlbar-reviewers,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
QA Whiteboard: [qa-triage-done-c152/b151][qa-ver-needed-c152/b151]
Flags: qe-verify+
QA Contact: dlucaci

Reproduced with Firefox 151.0a1 (2026-04-07) on macOS 15.
Verified as fixed with Firefox 152.0a1 (20260428214421) and Firefox 151.0b3 (20260427090318) on macOS 15, Windows 10 and Ubuntu 22.04.

Status: RESOLVED → VERIFIED
Has STR: --- → yes
QA Whiteboard: [qa-triage-done-c152/b151][qa-ver-needed-c152/b151] → [qa-triage-done-c152/b151][qa-ver-done-c152/b151]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: