Closed Bug 2030428 Opened 2 months ago Closed 2 months ago

Fix duplicated arrow function in browser_history_sidebar.js

Categories

(Firefox :: Sidebar, task)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: jsudiaman, Assigned: rishan.pgowda)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

In browser_history_sidebar.js,

() => () => rows[0].mainEl.href !== site

should be just:

() => rows[0].mainEl.href !== site

https://searchfox.org/firefox-main/rev/07e27bfce5acf193bdb89c7ba2aa73451a3e43b4/browser/components/sidebar/tests/browser/browser_history_sidebar.js#564

hi i would like to work on this

(In reply to Rishan from comment #1)

hi i would like to work on this

@Jonathan Sudiaman [:jsudiaman] can you assign me ?

(In reply to Rishan from comment #2)

(In reply to Rishan from comment #1)

hi i would like to work on this

@Jonathan Sudiaman [:jsudiaman] can you assign me ?

Assigned! Let me know if you need assistance.

Assignee: nobody → rishan.pgowda

@Jonathan Sudiaman [:jsudiaman], Submmitted a patch please review this
https://phabricator.services.mozilla.com/D292938
Thanks.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
QA Whiteboard: [qa-triage-done-c152/b151]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: