2030456 - Add Benchmarking Flags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

It's way too easy to accidentally measure something incorrectly with the JS shell

We should add benchmarking flags to make this as reliable and robust as possible.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2030456 - Add Benchmarking Modes to the JS Shell r?jandem

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2030456 - Test Benchmarking Modes for the JS Shell r?jandem

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2030456 - Add WASM benchmarking rules r?rhunt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7353698da83
https://hg.mozilla.org/integration/autoland/rev/634843cc2449
Add Benchmarking Modes to the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/763f43dd2fd3
https://hg.mozilla.org/integration/autoland/rev/38b12b1da4c8
Test Benchmarking Modes for the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/b4b8e1b82a05
https://hg.mozilla.org/integration/autoland/rev/acee17ca9512
Add WASM benchmarking rules r=rhunt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9011737c62b
https://hg.mozilla.org/integration/autoland/rev/120ee800e4db
Revert "Bug 2030456 - Add WASM benchmarking rules r=rhunt" for causing build bustages

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/120ee800e4db37cd500a3933030bf6d314dd2e59

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/js/src/shell/js.cpp(13384,16): error: no member named 'setAtStartup_extra_gc_poisoning' in 'JS::Prefs'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bbfa485f3fd0
https://hg.mozilla.org/integration/autoland/rev/81d01ae93ca0
Add Benchmarking Modes to the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/1bd0095c67ce
https://hg.mozilla.org/integration/autoland/rev/fc42c6698c25
Test Benchmarking Modes for the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/66d4e5500aaa
https://hg.mozilla.org/integration/autoland/rev/9a1f5f364786
Add WASM benchmarking rules r=rhunt

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/25aecba26ff6
https://hg.mozilla.org/integration/autoland/rev/72a9ae448f33
Revert "Bug 2030456 - Add WASM benchmarking rules r=rhunt" for causing spider-monkey failures

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing spider-monkey failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/72a9ae448f33ffd07dbfb1d20fa15497b8d167cd

Push with failures

Failure log -> Assertion failure: detail::libraryInitState == detail::InitState::Uninitialized (startup prefs must be set before calling JS_Init), at /builds/worker/checkouts/gecko/js/src/vm/Prefs.cpp:17

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4ee8f6df903
https://hg.mozilla.org/integration/autoland/rev/3204ed57d72b
Add Benchmarking Modes to the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/8a122654eaf8
https://hg.mozilla.org/integration/autoland/rev/100768d0ffff
Test Benchmarking Modes for the JS Shell r=jandem
https://github.com/mozilla-firefox/firefox/commit/a61a472ef892
https://hg.mozilla.org/integration/autoland/rev/d798c4111a14
Add WASM benchmarking rules r=rhunt

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3204ed57d72b
https://hg.mozilla.org/mozilla-central/rev/100768d0ffff
https://hg.mozilla.org/mozilla-central/rev/d798c4111a14