2030531 - [IPProtection] Address bar pill animation for every protection state

Status: RESOLVED FIXED

(Firefox for Android :: Privacy, task)

Description

[Mike a [:mavduevskiy]]

In the prototype I simply used a single (protected) icon with an added globe on top of it, but we probably want to explore being able to draw a combination of images - the protection icon as the base, "big" element, and a "globe" - meaning vpn - in the right bottom corner of it (side note - for RtL languages it should probably be left bottom). So whatever icons we are showing now, we keep showing those, but if the VPN is on, we show those with a globe icon with them.

waiting for a link
UPD: link

UPD2: the globe position might not be an issue for RtL languages; maybe check the RtL text positioning, but might not be high priority for phase 0.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: WIP: Bug 2030531 - Refactor the AnimatedPillButton

... to support various protection state icons with an overlay vpn status.

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 2030531 - Improve the AnimatedPillButton

The previous version was limited to displaying a single icon, requiring
an alternative set of "protection" icons with VPN enabled.

This patch takes a different approach, introducing support for an
optional overlay icon that is drawn on top of the main one, as well as
displaying the badge. That brings the element closer to [ActionButton],
in a sense that we can use same icons and badge behavior.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d01d4fc8f2c
https://hg.mozilla.org/integration/autoland/rev/2a5430d54a84
Improve the AnimatedPillButton r=android-reviewers,petru

Comment 4

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/2a5430d54a84