Closed
Bug 2030599
Opened 5 days ago
Closed 3 days ago
Remove commitPendingWrapperReservations call in WeakRefObject::preserveDOMWrapper
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
151 Branch
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
Except for this call site, commitPendingWrapperReservations is only called in GC/CC code. We should either remove the call or document why it's needed here (and not elsewhere).
|
Assignee | |
Comment 1•5 days ago
|
||
This is the only place where we call commitPendingWrapperPreservations outside GC/CC code.
|
||
Updated•5 days ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
|
|
||
Updated•5 days ago
|
Attachment #9568123 -
Attachment description: Bug 2030599 - Remove commitPendingWrapperPreservations call in WeakRefObject::preserveDOMWrapper. r?dthayer! → Bug 2030599 - Move commitPendingWrapperPreservations call to WeakRefObject::readBarrier. r?dthayer!,jonco!
|
|
||
Updated•5 days ago
|
Attachment #9568123 -
Attachment description: Bug 2030599 - Move commitPendingWrapperPreservations call to WeakRefObject::readBarrier. r?dthayer!,jonco! → Bug 2030599 - Move commitPendingWrapperPreservations call to WeakRefObject::readBarrier. r?dthayer!
Pushed by jdemooij@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/40c788468b2d
https://hg.mozilla.org/integration/autoland/rev/496be9d3e8d5
Move commitPendingWrapperPreservations call to WeakRefObject::readBarrier. r=dthayer
|
||
Comment 3•3 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
status-firefox151:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•