2030667 - Refactor MarketingAttributionService to allow reusing it for RTAMO

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, task)

Description

[Petru-Mugurel Lingurar [:petru]]

Bug 2028867 showed that we already have MarketingAttributionService which uses Google's InstallReferrerClient to infer where Fenix was installed from.

Since InstallReferrerClient is a heavy and sometimes slow service we should not use multiple separate instances of it but rather use the same instance to get the referrer data only once and then use this data for inferring various scenarios.

The goal of this ticket is to support refactoring MarketingAttributionService to a generic service that can be reused for inferring both attribution scenarios

• marketing scenarios
• Mozilla's own AMO webpage.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2030667 - part 1 - Rename MarketingAttributionService to InstallReferrerHandlingService r=#android-reviewers

Renamed this class separately from further changes to ensure that git will not
treat the combined actions as producing an entirely new file.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2030667 - part 2 - Refactor marketing attribution inference and tests r=#android-reviewers

Same functionality and code, just moved to different places.

In preparation of using InstallReferrerHandlingService for multiple scenarios
this patch extract the functionality of inferring the marketing attribution
details to a separate MarketingAttributionHandler.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a11de944b15c
https://hg.mozilla.org/integration/autoland/rev/31ff72a11b03
part 1 - Rename MarketingAttributionService to InstallReferrerHandlingService r=android-reviewers,moyin
https://github.com/mozilla-firefox/firefox/commit/52b235a6ba7d
https://hg.mozilla.org/integration/autoland/rev/01753c82fd77
part 2 - Refactor marketing attribution inference and tests r=android-reviewers,moyin

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/31ff72a11b03
https://hg.mozilla.org/mozilla-central/rev/01753c82fd77