2030731 - Display container-name in @container tooltip

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement)

Description

[Nicolas Chevobbe [:nchevobbe]]

When the container has a container-name different than none, we should display it

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 2030731 - [devtools] Show container name in @container tooltip. r=#devtools.

We now show the container-name property (when it's not none), in the tooltip
that is displayed on @container condition tooltip.
Along this change, we also show the tooltip when the condition does not match
any container element (e.g. there's no parent element with the specified container-name
value), with a label indicating that there's no container with such name.
From the server, that means that instead of returning a vague unmatched property,
we know pass a hasContainer property that we can use to include the "open in inspector"
icon in the condition.
The existing test for container queries is updated to assert those updates.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0960deadc3d5
https://hg.mozilla.org/integration/autoland/rev/4eee69abdc42
[devtools] Show container name in @container tooltip. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau.

Comment 3

[rperta]

https://hg.mozilla.org/mozilla-central/rev/4eee69abdc42