Send `FxaEvent::CancelOAuthFlow` when an oauth flow is cancelled.
Categories
(Firefox for Android :: Accounts and Sync, defect, P3)
Tracking
()
People
(Reporter: markh, Unassigned)
Details
If are in a "needs reauth" state, or in the future when you enter another oauth flow to grant new scopes, the FxA state machine is in a state other than "connected" (eg, "authenticating"). However, if you close that web-view we don't send a CancelOAuthFlow event, so the state machine remains in that intermediate state. We should hook the closing of the window and send that event.
|
||
Comment 1•1 month ago
•
|
||
We can do a "best effort" to close the window, however, that wouldn't account for background kills that we know occur reasonably often enough - maybe this is something that we can cover with FXA-11915? Accordingly, we would need to propagate that message from web channels back to the state machine to perform the clean-up and/or move it towards a CancelOAuthFlow.
|
Reporter | |
Comment 2•1 month ago
•
|
||
that wouldn't account for background kills
that's ok - we always startup correctly - the issue is when we start a "flow" but it never stops.
maybe this is something that we can cover with FXA-11915?
That should just be a mobile impl of bug 1990334? But more generally, you are correct in that this can only be a "best effort". eg, moving to a "real" tab would make this worse in that the tab's happily waiting for you, but you forgot it.
I think ultimately "authenticating" etc isn't an actual "account state", but somehow a "ui state" which somehow magically interacts with the "account state" something something :)
Description
•