2031036 - Failure to remove arguments in signature with "(anonymous namespace)"

Status: RESOLVED FIXED

(Socorro :: Signature, task, P3)

Description

[Andrew McCreight [:mccr8]]

I'm not sure if this should go in Signature or another component, but I came across this case where the arguments aren't being properly removed:

[@ SerializeJSONProperty(JSContext*, JS::Value const&, (anonymous namespace)::StringifyContext*) ]

Maybe the (anonymous namespace) stuff is breaking a regexp somewhere?

Example: bp-bcd33cb9-e432-49e5-b4ec-767ae0260408

Comment 1

[Andrew McCreight [:mccr8]]

It looks like the most common instance of this problem is [@ shutdownhang | mozilla::SpinEventLoopUntil(nsTSubstring<T> const&, (anonymous namespace)::ParentImpl::ShutdownBackgroundThread::<T>&&, nsIThread*) | (anonymous namespace)::ParentImpl::ShutdownBackgroundThread ] eg bp-43b718f4-e343-4b65-a47e-1d9f70260410

Comment 2

[Sven Marnach :sven]

Thanks for the report! Your guess is what I'd also guess as the root cause. Haseeb will take a look at this one.

Comment 3

[Haseeb Afzal]

Attachment: [mozilla-services/socorro] bug-2031036: Failure to remove arguments in signature with "(anonymous namespace)" (#7186)

Comment 4

[Haseeb Afzal]

Haseeb702 merged PR [mozilla-services/socorro]: bug-2031036: Failure to remove arguments in signature with "(anonymous namespace)" (#7186) in 190e266.

Comment 5

[Haseeb Afzal]

I have verified these changes in stage

Comment 6

[Sven Marnach :sven]

This has been deployed to prod in https://github.com/mozilla-services/socorro/releases/tag/v2026.06.08. Haseeb, could you please verify that this is working as intended?

Comment 7

[Haseeb Afzal]

I have verified that this patch is working as intended in prod.

Comment 8

[Andrew McCreight [:mccr8]]

Thanks for fixing this! I looked at the top signature with anonymous namespace and it looks like [@ shutdownhang | mozilla::SpinEventLoopUntil(nsTSubstring<T> const&, (anonymous namespace)::ParentImpl::ShutdownBackgroundThread::<T>&&, nsIThread*) | (anonymous namespace)::ParentImpl::ShutdownBackgroundThread ] is now going to correctly be [@ shutdownhang | mozilla::SpinEventLoopUntil | (anonymous namespace)::ParentImpl::ShutdownBackgroundThread ].