Closed Bug 2031348 Opened 7 months ago Closed 5 months ago

Fix a ruff warning in python/mach/mach/logging.py

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(firefox154 fixed)

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: Sylvestre, Assigned: Yogeshdangal66, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 external file)

Filing as a good first bug to learn workflows.

python/mach/mach/logging.py
  90:12  warning  Use format specifiers instead of percent format  UP031 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/python/mach/mach/logging.py#90

To run the linter:

./mach lint -W -l ruff python/mach/mach/logging.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Assignee: nobody → Yogeshdangal66
Status: NEW → ASSIGNED

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:Yogeshdangal66, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(sguelton)
Flags: needinfo?(Yogeshdangal66)

The patch needs to be rebased, Yogeshdangal66 you probably just need to run git pull -r origin main in your patch branch and fix the conflicts, then resubmit.

Flags: needinfo?(sguelton)
Attachment #9587353 - Attachment description: Bug 2031348 - Use f-string instead of percent format in python/mach/mach/logging.py r?#linter-reviewers → Bug 2031348 - Use f-string instead of percent format in python/mach/mach/logging.py r?#linter-reviewers!
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Flags: needinfo?(Yogeshdangal66)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: