Closed Bug 2031352 Opened 7 months ago Closed 6 months ago

Fix ruff warnings in python/mach/mach/decorators.py

Categories

(Developer Infrastructure :: Lint and Formatting, task)

task

Tracking

(firefox153 fixed)

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: Sylvestre, Assigned: akeemomosanya98, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 external file)

Filing as a good first bug to learn workflows.

python/mach/mach/decorators.py
  151:21  warning  Use format specifiers instead of percent format  UP031 (ruff)
  158:33  warning  Use format specifiers instead of percent format  UP031 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/python/mach/mach/decorators.py#151

To run the linter:

./mach lint -W -l ruff python/mach/mach/decorators.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Assignee: nobody → akeemomosanya98
Status: NEW → ASSIGNED

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:akeemomosanya98, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(akeemomosanya98)

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #2)

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:akeemomosanya98, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

The patch has been accepted on Phabricator (D298305). No additional changes are planned.

Flags: needinfo?(akeemomosanya98)
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: