2031356 - Fix a ruff warning in intl/unicharutil/util/base_chars.py

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filing as a good first bug to learn workflows.

intl/unicharutil/util/base_chars.py
  51:9  warning  `for` loop variable `char` overwritten by assignment target  PLW2901 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/intl/unicharutil/util/base_chars.py#51

To run the linter:

./mach lint -W -l ruff intl/unicharutil/util/base_chars.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[vyofgod]

Attachment: Bug 2031356 - Fix ruff PLW2901 by not overwriting loop variable in base_chars.py. r?hsivonen

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ffhpno1, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #2)

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ffhpno1, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

I requested landing.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/063286003e00
https://hg.mozilla.org/integration/autoland/rev/99ab10555aa5
Fix ruff PLW2901 by not overwriting loop variable in base_chars.py. r=hsivonen

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/99ab10555aa5