Closed Bug 2031357 Opened 2 months ago Closed 2 months ago

Fix a ruff warning in js/src/frontend/align_stack_comment.py

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(firefox152 fixed)

RESOLVED FIXED
152 Branch
Tracking Status
firefox152 --- fixed

People

(Reporter: Sylvestre, Assigned: ffhpno1, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 file)

Filing as a good first bug to learn workflows.

js/src/frontend/align_stack_comment.py
  41:13  warning  `for` loop variable `line` overwritten by assignment target  PLW2901 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/js/src/frontend/align_stack_comment.py#41

To run the linter:

./mach lint -W -l ruff js/src/frontend/align_stack_comment.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Assignee: nobody → ffhpno1
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://github.com/mozilla-firefox/firefox/commit/22e548652af6 https://hg.mozilla.org/integration/autoland/rev/2ff65b4325d7 Fix ruff PLW2901 by not overwriting loop variable in align_stack_comment.py. r=arai
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: