2031372 - Fix a clippy warning in toolkit/components/kvstore/src/task.rs

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filing as a good first bug to learn workflows.

toolkit/components/kvstore/src/task.rs
  191:9  warning  enclosing `Ok` and `?` operator are unneeded  clippy::needless_question_mark (clippy)

Link to the code:
https://searchfox.org/mozilla-central/source/toolkit/components/kvstore/src/task.rs#191

To run the linter:

./mach lint -W -l clippy toolkit/components/kvstore/src/task.rs

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[wenzhao]

Attachment: Bug 2031372 - Fix clippy needless_question_mark in kvstore. r?mak

Comment 2

[wenzhao]

Re-checked this on mozilla-central tip on 2026-04-18 with ./mach lint -W -l clippy toolkit/components/kvstore/src/task.rs --verbose, and it now reports 0 problems. I don't have a patch to submit anymore, so I'm unassigning this bug back to the pool.

Comment 3

[Marco Bonardo [:mak] (Away 10-21 August)]

I still see it, I ran CARGO_TARGET_DIR=obj-firefox/cargo cargo clippy -p kvstore
so reassigning and landing

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4fc740ffa8a0
https://hg.mozilla.org/integration/autoland/rev/f9d7d6ea5f0e
Fix clippy needless_question_mark in kvstore. r=mak

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f9d7d6ea5f0e