2031447 - Support configurable clippy warn/deny rules in clippy.yml

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2031447 - Support passing extra rustc flags to cargo subcommands via extra_rustflags r?#linter-reviewers

Append $(cargo_rustc_extra_flags) at the end of all force-cargo-*-% pattern
rules so that tools like clippy can inject driver flags (e.g. -W/-D) via an
environment variable.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2031447 - Support configurable clippy warn/deny rules in clippy.yml r?#linter-reviewers

Read warn and deny lists from clippy.yml and pass them as -W/-D flags
to the clippy driver. For gkrust crates, flags are passed via the
cargo_rustc_extra_flags env var. For non-gkrust crates, they are
appended directly to the cargo clippy command.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2031447 - Enable clippy::needless_return in clippy.yml r?#linter-reviewers

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2031447 - Add new directories to clippy r?#linter-reviewers

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 2031447 - Document how to enable additional clippy rules in clippy.yml r?#linter-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b86d4531536
https://hg.mozilla.org/integration/autoland/rev/0e1acbe483cc
Support passing extra rustc flags to cargo subcommands via extra_rustflags r=firefox-build-system-reviewers,sergesanspaille,ahochheiden
https://github.com/mozilla-firefox/firefox/commit/299b4f9a879d
https://hg.mozilla.org/integration/autoland/rev/2297bf4cf65b
Support configurable clippy warn/deny rules in clippy.yml r=linter-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/6e5e84b20201
https://hg.mozilla.org/integration/autoland/rev/4d2650e61290
Enable clippy::needless_return in clippy.yml r=linter-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/4cd78644928d
https://hg.mozilla.org/integration/autoland/rev/85e804efdc14
Add new directories to clippy r=linter-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/76babe304c22
https://hg.mozilla.org/integration/autoland/rev/e11c7c684f82
Document how to enable additional clippy rules in clippy.yml r=linter-reviewers,ahal

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0e1acbe483cc
https://hg.mozilla.org/mozilla-central/rev/2297bf4cf65b
https://hg.mozilla.org/mozilla-central/rev/4d2650e61290
https://hg.mozilla.org/mozilla-central/rev/85e804efdc14
https://hg.mozilla.org/mozilla-central/rev/e11c7c684f82

Comment 8

[Sylvestre Ledru [:Sylvestre]]

not all patches landed

Comment 9

[Sylvestre Ledru [:Sylvestre]]

sorry, wrong patch, it is fixed