Closed Bug 2031575 Opened 1 month ago Closed 15 days ago

IME is enabled when selection is in non-editable content in design mode

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox149 --- unaffected
firefox150 --- unaffected
firefox151 --- wontfix
firefox152 --- wontfix
firefox153 --- fixed

People

(Reporter: masayuki, Assigned: ltenenbaum)

References

(Regressed 1 open bug, Regression,
URL
)

Details

(Keywords: inputmethod, regression)

Attachments

(1 file)

Bug 2031575 - Disable IME when selection is in non-editable node. r=masayuki
48 bytes, text/x-phabricator-request
Details | Review

STR:

  1. Load the URL: data:text/html,<script>document.designMode="on"</script><body contenteditable="false">This is non-editable text.<br><button>button</button></body>
  2. Click text or button

ER:
IME should be disabled

AR:
IME is enabled

We need to improve HTMLEditor::GetPreferredIMEState() and add tests like widget/tests/test_ime_state_* and widget/tests/browser/browser_test_ime_state_*.

Flags: needinfo?(ltenenbaum)

Set release status flags based on info from the regressing bug 462735

status-firefox149: --- → unaffected
status-firefox150: --- → unaffected
status-firefox151: --- → affected
status-firefox-esr140: --- → unaffected

The bug is marked as tracked for firefox151 (nightly). However, the bug still isn't assigned and has low severity.

:hsinyi, could you please find an assignee and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(htsai)
Assignee: nobody → ltenenbaum
Flags: needinfo?(ltenenbaum)
Flags: needinfo?(htsai)

Set release status flags based on info from the regressing bug 462735

status-firefox152: --- → affected

:ltenenbaum, next week is the final full week of beta for Fx151, do you plan on fixing and requesting uplift in time?
I see the patch is still pending, so just checking on expectations.

Flags: needinfo?(ltenenbaum)

No this is quite a minor bug that already existed with contenteditable. So I think it's fine to leave it for 152.

status-firefox151: affected → wontfix
Flags: needinfo?(ltenenbaum)

The hack from bug 2032191 of moving the selection when the focused element is removed causes problems here (the ISM is notified of the content removal before the selection is moved, and moving the selection calls UpdateIMEState which triggers an assertion failure). So probably best to wait for bug 2034851 to be fixed before this.

Depends on: 2034851

Hi Leo, is this bug ready to move forward now?

status-firefox153: --- → affected
Flags: needinfo?(ltenenbaum)

Yes, I'll get to it soon :)
(I don't think it'll need to be uplifted to 152)

status-firefox152: affected → wontfix
Flags: needinfo?(ltenenbaum)

https://hg.mozilla.org/mozilla-central/rev/d3da2cef414d

Status: NEW → RESOLVED
Closed: 15 days ago
status-firefox153: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: