2031836 - Rename preferences related to a separate search engine in default private browsing mode

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

The naming of the preferences for the separate private default are not ideal, and do not reflect what we typically do today. Therefore we think we should rename the prefs as follows:

• browser.search.separatePrivateDefault -> browser.search.separatePrivateDefault.enabled
  • This is the preference behind the "Use a different default search engine in private windows" checkbox in preferences.
  • This should now default to false.
• browser.search.separatePrivateDefault.ui.enabled -> browser.search.separatePrivateDefault.featureGate
  • This is the preference that enables the feature in the UI.

We should also migrate the existing values for the preferences, to save disturbing users who have manually enabled it:

• browser.search.separatePrivateDefault.featureGate should be migrated directly from the original preference.
• browser.search.separatePrivateDefault.enabled should be set to true only if:
  • browser.search.separatePrivateDefault.ui.enabled was set to true, and browser.search.separatePrivateDefault does not have a user value of false.
    • The previous default for browser.search.separatePrivateDefault was true, so it will only have a user set value if the user turned it off. As we'll be removing the default value from all.js (because of removing the preference), we should check the user-value status. If it was not set to a user value, then it must have been true, hence we should maintain that true value if the UI was enabled.

Additionally we should also remove any user-set values for the previous preferences when migrating.

Comment 1

[CalebChan]

Attachment: Bug 2031836 - Rename separate private default search engine preferences and don't turn on the split by default. r=standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c3965fa0d595
https://hg.mozilla.org/integration/autoland/rev/903c4b53ff3c
Rename separate private default search engine preferences and don't turn on the split by default. r=Standard8,firefox-desktop-core-reviewers ,urlbar-reviewers,akulyk,hsohaney,chutten

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/903c4b53ff3c