2031837 - Update illustrations on Felt Privacy error pages to latest designs

Status: RESOLVED FIXED

(Firefox :: Security, task, P3)

Description

[Jack Brown]

Replace the Kit graphics in the Felt Privacy error pages with the latest versions:
https://www.figma.com/design/JHvur4UzdSsMtP0l4fAnsj/%E2%9C%8F%EF%B8%8F-Michelle-s-Illustration-Sandbox?node-id=1985-194367&t=au3sfcSGmzNjdtx0-4

Review from marketing:
https://mozilla.slack.com/archives/C09NHS1AJUF/p1770238113829849

Affected files:
toolkit/content/errors/net-error-illustrations.mjs
toolkit/content/net-error-card.mjs
toolkit/themes/shared/illustrations/*

Acceptance criteria:
Illustrations on cert error, net error, and other Felt Privacy error pages match the Figma spec at the above link.

Comment 1

[Jack Brown]

Attachment: Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=rking,#gfx-reviewers

Comment 2

[Jack Brown]

Attachment: be-careful.png

Comment 3

[Jack Brown]

Attachment: no-connection.png

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ec50c10ecb4
https://hg.mozilla.org/integration/autoland/rev/6678d79b1eca
Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b6198f56d80
https://hg.mozilla.org/integration/autoland/rev/135e244c3b91
Revert "Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao" for causing valgrind failures.

Comment 6

[agoloman]

Backed out for causing valgrind failures.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Jack Brown]

This is what I've gathered about the valgrind failures so far:

The valgrind test loads http://localhost:8000/ which has nothing running on it, so Firefox shows the "no connection" error page. This page loads the new illustration introduced in this patch, and the new SVG has something like 80+ gradient references whereas the old one didn't have any. So then VEX exhausts its temporary storage trying to deal with all the gradients.

It seems like our options are to either simplify the illustrations to reduce the gradient complexity, or find a way to fix the issue on the valgrind side.

I'm going to continue investigating.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55c035a4dc21
https://hg.mozilla.org/integration/autoland/rev/0e1483009b14
Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4ade994debd
https://hg.mozilla.org/integration/autoland/rev/fc8be7aeb554
Revert "Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman" for causing reftest failures at reftests/font-face

Comment 10

[Silaghi Andreea]

Backed out for causing reftest failures at reftests/font-face
Backout Link
Push with failures
Failure Log
Failure line REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/font-face/colrv1-06.html == layout/reftests/font-face/colrv1-06-ref.html | image comparison, max difference: 1, number of differing pixels: 320

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6793148cece
https://hg.mozilla.org/integration/autoland/rev/4f39a0cb3efe
Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4f39a0cb3efe