2031838 - Clear the private default search engine setting when the user unchecks the checkbox for using a different search in private windows

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently, when a user unchecks Use a different default search engine in private windows, and then later re-checks it, the engine that was previously selected for private mode is recovered. We think that we should not store the setting, since it is not active, and could be confusing that an old setting was retained.

The cause of this is that we're retaining the details of the private mode engine in the settings file - we should clear that when the setting is toggled.

Comment 1

[CalebChan]

Attachment: Bug 2031838 - Cleared private default search engine setting when user unchecks box for using a different search engine in private window. r=standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ff1916ae370
https://hg.mozilla.org/integration/autoland/rev/4be65ddad13d
Cleared private default search engine setting when user unchecks box for using a different search engine in private window. r=Standard8,akulyk

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4be65ddad13d