Closed Bug 2031914 Opened 7 months ago Closed 6 months ago

[wpt-sync] Sync PR 59161 - [wpt] Fix css/css-align/self-alignment/block-justify-self.html WPT.

Categories

(Core :: Layout: Block and Inline, task, P4)

task

Tracking

()

RESOLVED FIXED
152 Branch
Tracking Status
firefox152 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 59161 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/59161
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[wpt] Fix css/css-align/self-alignment/block-justify-self.html WPT.

This test had two issues:

  1. It was assuming that float:left etc was supported directly within
    grid layout. It is not, add a wrapper \<div> to the float tests.
  2. It was also assuming that "width:auto" would shrink to fit when we
    have auto margins in block layout. It does not.
    Making the top "grid" reference stretch would hide any failures so
    just delete this subtest.

There should be no behaviour change.

Fixed: 355683658
Change-Id: Ifb593dd057312b10fae5fa8879c35c68c19f3267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7758927
Auto-Submit: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: David Grogan \<dgrogan@chromium.org>
Commit-Queue: David Grogan \<dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1614026}

Component: web-platform-tests → Layout: Block and Inline
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 25 tests and 195 subtests

Status Summary

Firefox

OK : 16
PASS: 731[Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt] 739[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5717ea3a3d27 https://hg.mozilla.org/integration/autoland/rev/11ffcae37347 [wpt PR 59161] - [wpt] Fix css/css-align/self-alignment/block-justify-self.html WPT., a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
You need to log in before you can comment on or make changes to this bug.