2032064 - Calling CSSStyleProperties#hasLonghandProperty crashes the tab

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

hasLonghandProperty can be called on CSSStyleProperties object given https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/dom/webidl/CSSStyleDeclaration.webidl#32-33

[ChromeOnly]
boolean hasLonghandProperty(UTF8String property);

but when doing so, it actually crashes with Mozilla crash reason: MOZ_CRASH(called nsComputedDOMStyle::GetCSSDeclaration), which I think is because of this https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/layout/style/nsDOMCSSDeclaration.cpp#162

if (auto* decl = GetOrCreateCSSDeclaration(Operation::Read, nullptr)) {

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 2032064 - Implement nsComputedDOMStyle::HasLonghandProperty. r=#layout-reviewers.

This will be used by DevTools, in particular to know when a custom properties
is set (they can be empty, so getPropertyValue() isn't helpful here).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a62e813ba162
https://hg.mozilla.org/integration/autoland/rev/5ed9efad9a0a
Implement nsComputedDOMStyle::HasLonghandProperty. r=layout-reviewers,firefox-style-system-reviewers,emilio.

Comment 3

[Atila Butkovits]

Backed out as requested: https://hg.mozilla.org/integration/autoland/rev/5ed9efad9a0a

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/147d9c589d2d
https://hg.mozilla.org/integration/autoland/rev/62b14f7ca566
Revert "Bug 2032064 - Implement nsComputedDOMStyle::HasLonghandProperty. r=layout-reviewers,firefox-style-system-reviewers,emilio." as per request.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I had the test manifest change in the wrong patch, I'll move it here

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0652464014c3
https://hg.mozilla.org/integration/autoland/rev/eddf02a258af
Implement nsComputedDOMStyle::HasLonghandProperty. r=layout-reviewers,firefox-style-system-reviewers,emilio.

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/eddf02a258af

Comment 8

[rperta]

https://hg.mozilla.org/mozilla-central/rev/eddf02a258af